Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Adds anomaly description as an alert message for anomaly detection rule type #172473

Merged
merged 8 commits into from
Dec 5, 2023

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Dec 4, 2023

Summary

Closes #136391

Uses a description of the anomaly for the alert message for anomaly detection alerting rules with the record result type. This messages is used for example in the Reason field in the alert table and details flyout.

image

Checklist

@darnautov darnautov self-assigned this Dec 4, 2023
@darnautov darnautov requested a review from a team as a code owner December 4, 2023 13:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@darnautov darnautov force-pushed the ml-136391-alert-message branch from 21575d9 to e3c644b Compare December 4, 2023 13:52
@peteharverson peteharverson changed the title [ML] Add anomaly description as an alert message [ML] Add anomaly description as an alert message for anomaly detection rule type Dec 5, 2023
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested latest changes and LGTM.

Just left a suggestion for the i18n props.

@darnautov
Copy link
Contributor Author

@elasticmachine merge upstream

@darnautov darnautov enabled auto-merge (squash) December 5, 2023 17:48
@darnautov darnautov merged commit 50dabea into elastic:main Dec 5, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #33 / Uptime app with real-world data overview page pagination is cleared when filter criteria changes

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ml 1867 1868 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.6MB 3.6MB +69.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 5, 2023
@szabosteve szabosteve changed the title [ML] Add anomaly description as an alert message for anomaly detection rule type [ML] Adds anomaly description as an alert message for anomaly detection rule type Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Alerting Feature:Anomaly Detection ML anomaly detection :ml release_note:enhancement Team:ML Team label for ML (also use :ml) v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] Pass anomaly description to alert context
5 participants