Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Login refactor #172472

Merged
merged 7 commits into from
Dec 5, 2023
Merged

[Security Solution] Login refactor #172472

merged 7 commits into from
Dec 5, 2023

Conversation

MadameSheema
Copy link
Member

@MadameSheema MadameSheema commented Dec 4, 2023 •
edited
Loading

Summary

In this PR we are simplifying we are refactoring the login task we are using in Cypress in order to:

  • Have less code to maintain
  • Simplify the complexity
  • Make easier the integration with the SAML login for serverless

@MadameSheema MadameSheema changed the title login refactor [Security Solution] Login refactor Dec 5, 2023
@MadameSheema MadameSheema self-assigned this Dec 5, 2023
@MadameSheema MadameSheema added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.12.0 release_note:skip Skip the PR/issue when compiling release notes labels Dec 5, 2023
@MadameSheema MadameSheema marked this pull request as ready for review December 5, 2023 10:15
@MadameSheema MadameSheema requested a review from a team as a code owner December 5, 2023 10:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@MadameSheema MadameSheema enabled auto-merge (squash) December 5, 2023 13:58
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @MadameSheema

@MadameSheema MadameSheema merged commit b0219f9 into elastic:main Dec 5, 2023
39 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 5, 2023
@MadameSheema MadameSheema mentioned this pull request Dec 13, 2023
Open
43 tasks
@MadameSheema MadameSheema deleted the login-refactor branch June 28, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkirchan dkirchan dkirchan approved these changes

Assignees

@MadameSheema MadameSheema

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MadameSheema @elasticmachine @kibana-ci @dkirchan @kibanamachine