-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] enable feature flags #172464
[Fleet] enable feature flags #172464
Conversation
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
We might have a bug with secret field validation, one of the cypress tests failed with password field not being required: |
Check the logs for (edit) This might be a different error but I just fixed Cypress issues on the same form so it's on my mind 🙂 |
I think this is a different issue, enabling the output secrets feature flag changes how the kafka output field is rendered on the UI. |
we should probably exclude secrets from the AAD otherwise any change to that field will make that output non decryptable. |
Good point, excluded |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Summary
Closes #104986
Enable feature flags for
remoteESOutput
andoutputSecretsStorage
.The feature is ready when #172181 and elastic/fleet-server#3127 is merged.
Output secret storage issues are closed, so I think the feature flag for that should be enabled too. cc @jillguyonnet