Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EDR Workflows] Include timeout in saved query run #172347

Merged
merged 4 commits into from
Dec 6, 2023
Merged

[EDR Workflows] Include timeout in saved query run #172347

merged 4 commits into from
Dec 6, 2023

Conversation

szwarckonrad
Copy link
Contributor

#172138

Clicking "play" button on saved queries list didn't properly transfer timeout field through url change.

Screen.Recording.2023-12-01.at.11.13.57.mov

@szwarckonrad szwarckonrad added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Osquery v8.12.0 labels Dec 1, 2023
@szwarckonrad szwarckonrad self-assigned this Dec 1, 2023
@szwarckonrad szwarckonrad requested a review from a team as a code owner December 1, 2023 10:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

tomsonpl
tomsonpl approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@tomsonpl tomsonpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@szwarckonrad szwarckonrad enabled auto-merge (squash) December 6, 2023 13:14
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
osquery 1.0MB 1.0MB +127.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @szwarckonrad

@szwarckonrad szwarckonrad merged commit b721ff7 into elastic:main Dec 6, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsonpl tomsonpl tomsonpl approved these changes

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

Assignees

@szwarckonrad szwarckonrad

Labels
backport:skip This commit does not require backporting Osquery release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@szwarckonrad @elasticmachine @kibana-ci @patrykkopycinski @tomsonpl