Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule name to the default fields of alert table #172135

Closed

Conversation

maryam-saeidi
Copy link
Member

Summary

This PR adds the rule name as a default column in the alert table on the Alerts page:

image

The downside is that the rule name column will also be shown on the rule details page since the alert table configuration happens at the plugin level, but I think the benefit of seeing this field on the Alerts page outweighs this downside. (Especially when there are a lot of alerts firing, rule name helps with alert group)

@maryam-saeidi maryam-saeidi added the release_note:skip Skip the PR/issue when compiling release notes label Nov 29, 2023
@maryam-saeidi maryam-saeidi self-assigned this Nov 29, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

kibana-ci commented Nov 29, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Cypress Tests #11 / Detection ES|QL rules, creation ES|QL query validation shows error when non-aggregating ES|QL query does not return _id field shows error when non-aggregating ES|QL query does not return _id field
  • [job] [logs] FTR Configs #81 / InfraOps App Metrics UI Hosts View #Page Content Alerts Tab #AlertsTable should renders the correct number of cells
  • [job] [logs] FTR Configs #81 / InfraOps App Metrics UI Hosts View #Page Content Alerts Tab #AlertsTable should renders the correct number of cells
  • [job] [logs] FTR Configs #86 / ObservabilityApp Observability alerts > Alerts table Renders the correct number of cells
  • [job] [logs] FTR Configs #86 / ObservabilityApp Observability alerts > Alerts table Renders the correct number of cells

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 1.1MB 1.1MB +178.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maryam-saeidi

@maryam-saeidi
Copy link
Member Author

Closed in favor of #175119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants