[Cases] Suggest user profiles with read permission #172047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adcoelho
added
bug
adcoelho
changed the title
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
adcoelho
commented
Nov 28, 2023
| @@ -62,7 +59,7 @@ export default ({ getService }: FtrProviderContext): void => { | |||
| suggestedSecUsers = await suggestUserProfiles({ | |||
| supertest: supertestWithoutAuth, | |||
| req: { | |||
| name: secOnlyInfo.username!, | |||
| name: 'all_spaces', | |||
There was a problem hiding this comment.
securityPluginStart.userProfiles.suggest seems to do a fuzzy match on the name field so sec_user_all_spaces was now returning another security user, sec_user_read. Changing it here guarantees the right profile is returned.
adcoelho
added
release_note:fix
and removed
release_note:skip
cnasikas
approved these changes
Nov 28, 2023
| auth: { user: superUser, space: 'space1' }, | ||
| }); | ||
|
|
||
| expectSnapshot(profiles.map(({ user, data }) => ({ user, data }))).toMatchInline(` |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @adcoelho |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #171446
Summary
We will now also suggest users with only
Read Casespermissions for case assignment.Release notes
Fixed a bug that prevented users with read permission from being assigned to cases.