Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[maps] fix tile errors displayed when layer is no longer using tiles #172019

Merged
merged 5 commits into from
Nov 28, 2023
Merged

[maps] fix tile errors displayed when layer is no longer using tiles #172019

merged 5 commits into from
Nov 28, 2023

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Nov 27, 2023

Closes #172013

PR updates TileStatusTracker to clear tile error cache when layer is not tiled.

@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes Feature:Maps v8.12.0 labels Nov 27, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese requested a review from a team as a code owner November 27, 2023 20:16
@nreese
Copy link
Contributor Author

nreese commented Nov 27, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.9MB 2.9MB +302.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

nickpeihl
nickpeihl approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

code review and verified the tile errors clear when switching to geojson.

@nreese nreese merged commit d81c367 into elastic:main Nov 28, 2023
26 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickpeihl nickpeihl nickpeihl approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Maps release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[maps] tile errors displayed when layer is no longer using tiles
5 participants
@nreese @elasticmachine @kibana-ci @nickpeihl @kibanamachine