Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Validates and limits threading parameters for starting model deployment #171921

Merged
merged 4 commits into from
Nov 27, 2023
Merged

[ML] Validates and limits threading parameters for starting model deployment #171921

merged 4 commits into from
Nov 27, 2023

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Nov 24, 2023 •
edited
Loading

Summary

Closes #171883

This PR adds:

  • Limiting options for "Threads per allocation" control for a model deployment based on the max_single_ml_node_processors limit
  • Validation of the number of allocation according to the total_ml_processors field
image

Checklist

@darnautov darnautov requested a review from a team as a code owner November 24, 2023 13:36
@darnautov darnautov added release_note:enhancement :ml Feature:3rd Party Models ML 3rd party models Team:ML Team label for ML (also use :ml) v8.12.0 labels Nov 24, 2023
@darnautov darnautov self-assigned this Nov 24, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@darnautov darnautov requested a review from szabosteve November 24, 2023 13:37
szabosteve
szabosteve approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI text LGMT!

jgowdyelastic
jgowdyelastic approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

droberts195
droberts195 reviewed Nov 24, 2023
View reviewed changes
x-pack/plugins/ml/public/application/model_management/deployment_setup.tsx Outdated Show resolved Hide resolved
x-pack/plugins/ml/public/application/model_management/deployment_setup.tsx
fullWidth
min={1}
max={totalMlProcessors}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does undefined mean "no max" here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, exactly

@darnautov
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.6MB 3.6MB +728.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

peteharverson
peteharverson approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and LGTM

@darnautov darnautov merged commit 808990a into elastic:main Nov 27, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 27, 2023
@darnautov darnautov deleted the ml-171883-limit-allocation-params branch November 27, 2023 13:08
@szabosteve szabosteve changed the title [ML] Validate and limit threading parameters for starting model deployment [ML] Validates and limits threading parameters for starting model deployment Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szabosteve szabosteve szabosteve approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@peteharverson peteharverson peteharverson approved these changes

@droberts195 droberts195 Awaiting requested review from droberts195

Assignees

@darnautov darnautov

Labels
backport:skip This commit does not require backporting Feature:3rd Party Models ML 3rd party models :ml release_note:enhancement Team:ML Team label for ML (also use :ml) v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Limit allocation parameters for start model deployment based on the cluster configuration
8 participants
@darnautov @elasticmachine @kibana-ci @peteharverson @droberts195 @jgowdyelastic @szabosteve @kibanamachine