Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Report render completion for the Anomaly swim lane embeddable #171879

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

darnautov
Copy link
Contributor

Summary

Reports render completion for the Anomaly swim lane embeddable with the onRenderChange callback by elastic-charts.

@darnautov darnautov requested a review from a team as a code owner November 23, 2023 16:18
@darnautov darnautov added the :ml label Nov 23, 2023
@darnautov darnautov added Feature:Anomaly Detection ML anomaly detection Team:ML Team label for ML (also use :ml) Feature:Embeddables Relating to the Embeddable system v8.12.0 labels Nov 23, 2023
@darnautov darnautov self-assigned this Nov 23, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Also gave a dashboard with some swim lane embeddables a test.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.6MB 3.6MB -5.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
ml 559 558 -1

Total ESLint disabled count

id before after diff
ml 562 561 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@darnautov darnautov added the release_note:skip Skip the PR/issue when compiling release notes label Nov 24, 2023
@darnautov darnautov merged commit 40e9ee3 into elastic:main Nov 24, 2023
27 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 24, 2023
@darnautov darnautov deleted the ml-swim-lane-render-complete branch November 24, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Anomaly Detection ML anomaly detection Feature:Embeddables Relating to the Embeddable system :ml release_note:skip Skip the PR/issue when compiling release notes Team:ML Team label for ML (also use :ml) v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants