-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES|QL] Displays the columns as they are returned from the query #171874
Conversation
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review only 👍
Is there any particular reason to have this sanitize
in the first place? This would be helpful in case anybody else would reintroduce it again.
@dej611 I have no idea tbh. I think that Joe who wrote the strategy just took it from the SQL strategy as it was. I hadnt realized that we were doing that actually. Not sure what we are doing this in SQL though. Maybe @lukasolson knows |
I'm also not sure. |
Summary
Closes #171855
Removes the sanitize function from ES|QL strategy
Now
Before