Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] Displays the columns as they are returned from the query #171874

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Nov 23, 2023

Summary

Closes #171855

Removes the sanitize function from ES|QL strategy

Now
image

Before
Screenshot 2023-11-23 at 4 29 38 PM

@stratoula stratoula added Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Feature:ES|QL ES|QL related features in Kibana v8.12.0 release_note:fix labels Nov 23, 2023
@kertal kertal added the loe:small Small Level of Effort label Nov 23, 2023
@stratoula stratoula marked this pull request as ready for review November 24, 2023 06:55
@stratoula stratoula requested review from a team as code owners November 24, 2023 06:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@stratoula stratoula changed the title [ES|QL] Removes the sanitize function from the strategy [ES|QL] Displays the columns as they are returned from the query Nov 24, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 414.5KB 414.4KB -55.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only 👍

Is there any particular reason to have this sanitize in the first place? This would be helpful in case anybody else would reintroduce it again.

@stratoula
Copy link
Contributor Author

@dej611 I have no idea tbh.

I think that Joe who wrote the strategy just took it from the SQL strategy as it was. I hadnt realized that we were doing that actually. Not sure what we are doing this in SQL though. Maybe @lukasolson knows

@stratoula stratoula merged commit e29e316 into elastic:main Nov 27, 2023
27 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 27, 2023
@lukasolson
Copy link
Member

I think that Joe who wrote the strategy just took it from the SQL strategy as it was. I hadnt realized that we were doing that actually. Not sure what we are doing this in SQL though. Maybe @lukasolson knows

I'm also not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Discover Discover Application Feature:ES|QL ES|QL related features in Kibana loe:small Small Level of Effort release_note:fix Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ES|QL][Discover] Wrong column names for generated fields with parenthesis
7 participants