[ML] Rename index pattern references to data view (Part 2) #171820
Conversation
walterra
added
:ml
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
| @@ -129,6 +129,6 @@ export function timeBasedIndexCheck(dataView: DataView, showNotification = false | |||
| * Returns true if the data view index pattern contains a : | |||
| * which means it is cross-cluster | |||
| */ | |||
| export function isCcsIndexPattern(dataViewIndexPattern: string) { | |||
| return dataViewIndexPattern.includes(':'); | |||
| export function isCcsEsIndexPattern(esIndexPattern: string) { | |||
There was a problem hiding this comment.
I don't think it's necessary have the prefix es in these variable names.
With this change, all references to indexPattern will be obvious that it’s referring to the sting which matches indices.
In other places in the kibana codebase they don't use a prefix e.g. https://github.com/elastic/kibana/blob/426a379f311fe76fccfe1fbf260ca0ea1b41f772/src/plugins/data_views/common/data_views/abstract_data_views.ts#L207C8-L207C8
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @walterra |
Summary
Follow up to #171627.
References that referred to Elasticsearch index patterns were prefixes with(reverted)es.Note this doesn't cover the whole ml owned codebase but just code related to data frame analytics.
Checklist