Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Fix authentication types for alerting rule enable API #171807

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Nov 22, 2023

Summary

Fixes #171761

The openAPI specification does not need to be updated, since it already has the security options set at the root level and they're not overridden at the operation level:

@lcawl lcawl added Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) docs v8.8.3 v8.9.3 v8.12.0 v8.10.5 v8.11.2 labels Nov 22, 2023
Copy link
Contributor

Documentation preview:

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@lcawl lcawl marked this pull request as ready for review November 22, 2023 22:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@lcawl lcawl requested a review from pmuellr November 22, 2023 22:47
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@lcawl lcawl merged commit 9adcfd0 into elastic:main Nov 27, 2023
25 checks passed
@lcawl lcawl deleted the alerting-api-enable branch November 27, 2023 16:24
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 27, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 27, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 27, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 27, 2023
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.10
8.11
8.8
8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 27, 2023
…lastic#171807) (elastic#172000)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[DOCS] Fix authentication types for alerting rule enable API
(elastic#171807)](elastic#171807)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-11-27T16:24:43Z","message":"[DOCS]
Fix authentication types for alerting rule enable API
(elastic#171807)","sha":"9adcfd072f9d538f7b3c91b2d9c3ba5f4e8c3dd8","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Alerting","release_note:skip","Team:ResponseOps","docs","v8.8.3","v8.9.3","v8.12.0","v8.10.5","v8.11.2"],"number":171807,"url":"https://github.com/elastic/kibana/pull/171807","mergeCommit":{"message":"[DOCS]
Fix authentication types for alerting rule enable API
(elastic#171807)","sha":"9adcfd072f9d538f7b3c91b2d9c3ba5f4e8c3dd8"}},"sourceBranch":"main","suggestedTargetBranches":["8.8","8.9","8.10","8.11"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.9","label":"v8.9.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/171807","number":171807,"mergeCommit":{"message":"[DOCS]
Fix authentication types for alerting rule enable API
(elastic#171807)","sha":"9adcfd072f9d538f7b3c91b2d9c3ba5f4e8c3dd8"}},{"branch":"8.10","label":"v8.10.5","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.11","label":"v8.11.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Lisa Cawley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.8.3 v8.9.3 v8.10.5 v8.11.2 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ResponseOps] docs reference APIs as "This API supports Token-based authentication only"
5 participants