Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[inspector] clusters tab search bar #171806

Merged
merged 13 commits into from
Nov 27, 2023
Merged

[inspector] clusters tab search bar #171806

merged 13 commits into from
Nov 27, 2023

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Nov 22, 2023

#167666

PR adds table sorting. In picture below, table is sorted by request time
Screenshot 2023-11-22 at 2 13 41 PM

PR adds search bar. Screen shot below shows status filter popover
Screenshot 2023-11-22 at 2 14 18 PM

Then, once search selections are made, the search bar filters the health bar and table. In the screen shot below, the table only display remote1 because its the only cluster that matches the status.
Screenshot 2023-11-22 at 2 14 11 PM

test instructions

  1. Follow CCS setup instructions from CCS meta ticket #164350.
  2. Open discover
  3. Open inspector "clusters and shards" tab. Try sorting table and using search bar to narrow clusters

@nreese nreese changed the title Issue 167666 [inspector] clusters tab search bar Nov 22, 2023
@nreese
Copy link
Contributor Author

nreese commented Nov 27, 2023

@elasticmachine merge upstream

@nreese nreese marked this pull request as ready for review November 27, 2023 15:27
@nreese nreese requested a review from a team as a code owner November 27, 2023 15:27
@nreese nreese added release_note:enhancement Feature:Inspector Inspector infrastructure and implementations Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.12.0 labels Nov 27, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson ThomThomson self-requested a review November 27, 2023 16:35
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #82 / Entity Analytics - Risk Engine @ess @serverless Risk Scoring Task Execution with auditbeat data with some alerts containing hosts and others containing users @skipInQA calculates and persists risk scores for both types of entities

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
inspector 58 59 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
inspector 26.4KB 28.0KB +1.6KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! Tested this locally with the described CCS setup and looked through the changes.


import React from 'react';
import type { ClusterDetails } from '@kbn/es-types';
import { render, screen, fireEvent } from '@testing-library/react';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice looking RTL tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Inspector Inspector infrastructure and implementations release_note:enhancement Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants