-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[inspector] clusters tab search bar #171806
Conversation
@elasticmachine merge upstream |
Pinging @elastic/kibana-presentation (Team:Presentation) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM! Tested this locally with the described CCS setup and looked through the changes.
|
||
import React from 'react'; | ||
import type { ClusterDetails } from '@kbn/es-types'; | ||
import { render, screen, fireEvent } from '@testing-library/react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice looking RTL tests!
#167666
PR adds table sorting. In picture below, table is sorted by request time

PR adds search bar. Screen shot below shows status filter popover

Then, once search selections are made, the search bar filters the health bar and table. In the screen shot below, the table only display remote1 because its the only cluster that matches the status.

test instructions