[Security Solution] Making manage_lists.cy.ts tests more robust
#171675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadameSheema
changed the title
manage_lists.cy.ts tests more robust
MadameSheema
added
v8.12.0
Team:Detections and Resp
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
yctercero
approved these changes
Nov 21, 2023
|
@elasticmachine run elasticsearch-ci/docs |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is part of the effort we are making to have more robust tests for serverless and have them ready for the second quality gate (QA environment - real serverless project.)
Inside
manage_listsspec we have an export test that relies on a hardcoded user for the assertionsystem_indices_super_user. The problem is, that this user does not exist in deployed project, in order to make the test less flaky and make it work on QA as well, we are using theELASTICSEARCH_USERNAMEvalue of the environment variable which has the name of the user interacting with our application.I've noticed also that in real deployed projects, some toaster errors are unrelated to the test behavior, as you are already closing some toaster errors when this happens, I've added an extra-safe guard when executing the export.