[SecuritySolution] Fix timeline saving / prevent epic from crashing #171674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmonschke
added
release_note:fix
Team:Threat Hunting:Investigations
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @janmonschke |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 21, 2023
…lastic#171674) ## Summary Fixes elastic#168194 Under some circumstance, when navigating to the timelines page, we would get a runtime exception for `state.tableById[action.id]` not being defined. When that happened, the redux store would be in a broken state. This PR makes the responsible destructuring assignment more save. (cherry picked from commit 10f4228)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
jpdjere
pushed a commit
to jpdjere/kibana
that referenced
this pull request
Nov 22, 2023
…shing (elastic#171674) (elastic#171692) # Backport This will backport the following commits from `main` to `8.11`: - [[SecuritySolution] Fix timeline saving / prevent epic from crashing (elastic#171674)](elastic#171674) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jan Monschke","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-11-21T21:42:00Z","message":"[SecuritySolution] Fix timeline saving / prevent epic from crashing (elastic#171674)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/168194\r\n\r\nUnder some circumstance, when navigating to the timelines page, we would\r\nget a runtime exception for `state.tableById[action.id]` not being\r\ndefined. When that happened, the redux store would be in a broken state.\r\n\r\nThis PR makes the responsible destructuring assignment more save.","sha":"10f422836be9690201cdea2fbccfc94adb4cd6a4","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Threat Hunting:Investigations","backport:prev-minor","ci:cloud-deploy","v8.11.0","v8.12.0","v8.12.1","v8.11.2"],"number":171674,"url":"https://github.com/elastic/kibana/pull/171674","mergeCommit":{"message":"[SecuritySolution] Fix timeline saving / prevent epic from crashing (elastic#171674)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/168194\r\n\r\nUnder some circumstance, when navigating to the timelines page, we would\r\nget a runtime exception for `state.tableById[action.id]` not being\r\ndefined. When that happened, the redux store would be in a broken state.\r\n\r\nThis PR makes the responsible destructuring assignment more save.","sha":"10f422836be9690201cdea2fbccfc94adb4cd6a4"}},"sourceBranch":"main","suggestedTargetBranches":["8.11","8.12"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/171674","number":171674,"mergeCommit":{"message":"[SecuritySolution] Fix timeline saving / prevent epic from crashing (elastic#171674)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/168194\r\n\r\nUnder some circumstance, when navigating to the timelines page, we would\r\nget a runtime exception for `state.tableById[action.id]` not being\r\ndefined. When that happened, the redux store would be in a broken state.\r\n\r\nThis PR makes the responsible destructuring assignment more save.","sha":"10f422836be9690201cdea2fbccfc94adb4cd6a4"}},{"branch":"8.12","label":"v8.12.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Jan Monschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #168194
Under some circumstance, when navigating to the timelines page, we would get a runtime exception for
state.tableById[action.id]not being defined. When that happened, the redux store would be in a broken state.This PR makes the responsible destructuring assignment more save.