Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dataset quality] Including integration information within stats #171663

Merged

Conversation

yngrdyn
Copy link
Contributor

@yngrdyn yngrdyn commented Nov 21, 2023

Changes

  • sortOrder was removed as a param
  • GET /internal/dataset_quality/data_streams/stats now includes information related to integrations (name, title, version, icons)

Response now looks like

{
  "items": [
    {
      "name": "logs-elastic_agent-default",
      "size": "1.5mb",
      "size_bytes": 1645068,
      "last_activity": 1700378618104
    },
    {
      "name": "logs-elastic_agent.filebeat-default",
      "size": "3.6mb",
      "size_bytes": 3860281,
      "last_activity": 1700472909107
    },
    {
      "name": "logs-elastic_agent.metricbeat-default",
      "size": "1.6mb",
      "size_bytes": 1773572,
      "last_activity": 1700142440834
    },
    {
      "name": "logs-system.auth-default",
      "integration": "system",
      "size": "6.8mb",
      "size_bytes": 7226358,
      "last_activity": 1700472604014
    },
    {
      "name": "logs-system.syslog-default",
      "integration": "system",
      "size": "1.2gb",
      "size_bytes": 1302089724,
      "last_activity": 1700473867000
    }
  ],
  "integrations": [
    {
      "name": "system",
      "title": "System",
      "version": "1.49.0",
      "icons": [
        {
          "src": "/img/system.svg",
          "path": "/package/system/1.49.0/img/system.svg",
          "title": "system",
          "size": "1000x1000",
          "type": "image/svg+xml"
        }
      ]
    }
  ]
}

@yngrdyn yngrdyn requested review from a team as code owners November 21, 2023 15:40
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@yngrdyn yngrdyn added the release_note:skip Skip the PR/issue when compiling release notes label Nov 21, 2023
@yngrdyn yngrdyn force-pushed the including-integration-information-within-datasets branch from d2a299b to aa659d9 Compare November 21, 2023 15:43
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mohamedhamed-ahmed mohamedhamed-ahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this great work

@yngrdyn yngrdyn force-pushed the including-integration-information-within-datasets branch from 217359e to 59d7adb Compare November 22, 2023 11:45
…ithub.com:yngrdyn/kibana into including-integration-information-within-datasets
@yngrdyn yngrdyn force-pushed the including-integration-information-within-datasets branch from 9327570 to 23b6f81 Compare November 22, 2023 13:55
@kibana-ci
Copy link
Collaborator

kibana-ci commented Nov 22, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 12.8MB 12.8MB +6.4KB
securitySolutionServerless 330.6KB 336.9KB +6.3KB
total +12.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolutionServerless 41.7KB 41.7KB -1.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
datasetQuality 9 7 -2

Total ESLint disabled count

id before after diff
datasetQuality 11 9 -2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yngrdyn yngrdyn merged commit 74dea1e into elastic:main Nov 22, 2023
28 checks passed
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Nov 22, 2023
@yngrdyn yngrdyn self-assigned this Nov 22, 2023
@yngrdyn yngrdyn added the Team:obs-ux-logs Observability Logs User Experience Team label Mar 21, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants