Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OAS] Migrate machine learning APIs to v3.1.0 #171594

Merged
merged 5 commits into from
Nov 23, 2023
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Nov 21, 2023

Summary

This PR changes the openAPI specification from 3.0.1 to 3.1.0 for the machine learning APIs. The changes are based on https://www.openapis.org/blog/2021/02/16/migrating-from-openapi-3-0-to-3-1-0

In particular, it increments the version and changes occurrences of example: to examples:.

@lcawl lcawl added WIP Work in progress release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting docs labels Nov 21, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@lcawl lcawl added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed WIP Work in progress backport:skip This commit does not require backporting labels Nov 22, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Serverless Investigations - Security Solution Cypress Tests #2 / Correlation tab should update timeline after removing eql should update timeline after removing eql

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl marked this pull request as ready for review November 23, 2023 16:39
@lcawl lcawl requested a review from a team as a code owner November 23, 2023 16:39
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🏎️

@lcawl lcawl merged commit 2f258a2 into elastic:main Nov 23, 2023
@lcawl lcawl deleted the ml-oas-31 branch November 23, 2023 19:46
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.11 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.11:
- [SecuritySolution] Remove @kbn/subscription-tracking (#171801)

Manual backport

To create the backport manually run:

node scripts/backport --pr 171594

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit to lcawl/kibana that referenced this pull request Nov 23, 2023
@lcawl
Copy link
Contributor Author

lcawl commented Nov 23, 2023

💚 All backports created successfully

Status Branch Result
8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit to lcawl/kibana that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) docs release_note:skip Skip the PR/issue when compiling release notes v8.11.2 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants