Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Updating screenshot #171549

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Conversation

amyjtechwriter
Copy link
Contributor

@amyjtechwriter amyjtechwriter commented Nov 20, 2023

Summary

Updating the screenshot on the 'Create links to other dashboards' page in the 'Make dashboards interactive' section of the Kibana docs.

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

Copy link
Contributor

Documentation preview:

Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new screenshot looks good! Why keep the old screenshot in the Repo rather than replacing it?

@amyjtechwriter
Copy link
Contributor Author

...I forgot to delete it 🙃. Let me do that now @ThomThomson, thanks for catching it

@amyjtechwriter amyjtechwriter requested review from ThomThomson and a team November 20, 2023 15:07
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@amyjtechwriter amyjtechwriter merged commit a968a2e into elastic:main Nov 20, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 20, 2023
## Summary

Updating the screenshot on the '[Create links to other
dashboards](https://www.elastic.co/guide/en/kibana/current/dashboard-links.html)'
page in the 'Make dashboards interactive' section of the Kibana docs.

(cherry picked from commit a968a2e)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 20, 2023
# Backport

This will backport the following commits from `main` to `8.11`:
- [[DOCS] Updating screenshot
(elastic#171549)](elastic#171549)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"amyjtechwriter","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-11-20T15:24:53Z","message":"[DOCS]
Updating screenshot (elastic#171549)\n\n## Summary\r\n\r\nUpdating the
screenshot on the '[Create links to
other\r\ndashboards](https://www.elastic.co/guide/en/kibana/current/dashboard-links.html)'\r\npage
in the 'Make dashboards interactive' section of the Kibana
docs.","sha":"a968a2e3f5cdef37e713cf48693f5a30c1135bc8","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","v8.12.0","v8.11.2"],"number":171549,"url":"https://github.com/elastic/kibana/pull/171549","mergeCommit":{"message":"[DOCS]
Updating screenshot (elastic#171549)\n\n## Summary\r\n\r\nUpdating the
screenshot on the '[Create links to
other\r\ndashboards](https://www.elastic.co/guide/en/kibana/current/dashboard-links.html)'\r\npage
in the 'Make dashboards interactive' section of the Kibana
docs.","sha":"a968a2e3f5cdef37e713cf48693f5a30c1135bc8"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/171549","number":171549,"mergeCommit":{"message":"[DOCS]
Updating screenshot (elastic#171549)\n\n## Summary\r\n\r\nUpdating the
screenshot on the '[Create links to
other\r\ndashboards](https://www.elastic.co/guide/en/kibana/current/dashboard-links.html)'\r\npage
in the 'Make dashboards interactive' section of the Kibana
docs.","sha":"a968a2e3f5cdef37e713cf48693f5a30c1135bc8"}},{"branch":"8.11","label":"v8.11.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: amyjtechwriter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Docs v8.11.2 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants