[Custom threshold] Add an adHoc data view API integration test #171508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryam-saeidi
added
the
release_note:skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
maryam-saeidi
commented
Nov 20, 2023
| @@ -64,5 +64,8 @@ export async function createRule<Params = ThresholdParams>({ | |||
| rule_type_id: ruleTypeId, | |||
| actions, | |||
| }); | |||
| if (body.statusCode && body.statusCode !== 200) { | |||
| throw new Error(body.message); | |||
There was a problem hiding this comment.
In case of an error, the message was not visible in logs, so I added this condition to surface the error message.
shahzad31
reviewed
Nov 20, 2023
Comment on lines
+42
to
+52
| const MOCKED_AD_HOC_DATA_VIEW = { | ||
| id: DATA_VIEW_ID, | ||
| title: DATE_VIEW, | ||
| timeFieldName: '@timestamp', | ||
| sourceFilters: [], | ||
| fieldFormats: {}, | ||
| runtimeFieldMap: {}, | ||
| allowNoIndex: false, | ||
| name: DATE_VIEW_NAME, | ||
| allowHidden: false, | ||
| }; |
There was a problem hiding this comment.
might be worth using this util from data plugin createStubDataView
There was a problem hiding this comment.
Update
I tried it but got this error:
shahzad31
reviewed
Nov 20, 2023
x-pack/test/alerting_api_integration/observability/helpers/alerting_api_helper.ts
Outdated
Show resolved
Hide resolved
shahzad31
approved these changes
Nov 20, 2023
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.12.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #170438
Summary
This PR adds an ad hoc data view API integration test by changing one of the existing custom threshold API integration tests.