Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OAS] Migrate connector APIs to v3.1.0 #171464

Merged
merged 6 commits into from
Nov 24, 2023
Merged

[OAS] Migrate connector APIs to v3.1.0 #171464

merged 6 commits into from
Nov 24, 2023

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Nov 17, 2023

Summary

This PR changes the openAPI specification from 3.0.1 to 3.1.0 for the connector APIs. The changes are based on https://www.openapis.org/blog/2021/02/16/migrating-from-openapi-3-0-to-3-1-0

In particular, occurrences of nullable: true are replaced and example: is replaced by examples:.

@lcawl lcawl added WIP Work in progress release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) docs Feature:Actions/ConnectorsManagement Issues related to Connectors Management UX labels Nov 17, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@lcawl lcawl added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting WIP Work in progress labels Nov 22, 2023
@lcawl lcawl marked this pull request as ready for review November 23, 2023 16:54
@lcawl lcawl requested a review from a team as a code owner November 23, 2023 16:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit 14886bf into elastic:main Nov 24, 2023
@lcawl lcawl deleted the 30-31 branch November 24, 2023 20:51
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.11 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 171464

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit to lcawl/kibana that referenced this pull request Nov 25, 2023
@lcawl
Copy link
Contributor Author

lcawl commented Nov 25, 2023

💚 All backports created successfully

Status Branch Result
8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

edmarmoretti pushed a commit to edmarmoretti/kibana-pt-br that referenced this pull request Nov 28, 2023
…ic#171945)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[OAS] Migrate connector APIs to v3.1.0
(elastic#171464)](elastic#171464)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-11-24T20:51:14Z","message":"[OAS]
Migrate connector APIs to v3.1.0
(elastic#171464)","sha":"14886bf8b8a1629535e9b3ce0d6a6485b98299e5","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","docs","Feature:Actions/ConnectorsManagement","backport:prev-minor","v8.12.0"],"number":171464,"url":"https://github.com/elastic/kibana/pull/171464","mergeCommit":{"message":"[OAS]
Migrate connector APIs to v3.1.0
(elastic#171464)","sha":"14886bf8b8a1629535e9b3ce0d6a6485b98299e5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/171464","number":171464,"mergeCommit":{"message":"[OAS]
Migrate connector APIs to v3.1.0
(elastic#171464)","sha":"14886bf8b8a1629535e9b3ce0d6a6485b98299e5"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) docs Feature:Actions/ConnectorsManagement Issues related to Connectors Management UX release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.11.2 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants