-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OAS] Migrate connector APIs to v3.1.0 #171464
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcawl
added
WIP
Work in progress
release_note:skip
Skip the PR/issue when compiling release notes
backport:skip
This commit does not require backporting
Team:ResponseOps
Label for the ResponseOps team (formerly the Cases and Alerting teams)
docs
Feature:Actions/ConnectorsManagement
Issues related to Connectors Management UX
labels
Nov 17, 2023
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
lcawl
added
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
and removed
backport:skip
This commit does not require backporting
WIP
Work in progress
labels
Nov 22, 2023
Pinging @elastic/response-ops (Team:ResponseOps) |
cnasikas
approved these changes
Nov 24, 2023
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
lcawl
added a commit
to lcawl/kibana
that referenced
this pull request
Nov 25, 2023
(cherry picked from commit 14886bf)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
edmarmoretti
pushed a commit
to edmarmoretti/kibana-pt-br
that referenced
this pull request
Nov 28, 2023
…ic#171945) # Backport This will backport the following commits from `main` to `8.11`: - [[OAS] Migrate connector APIs to v3.1.0 (elastic#171464)](elastic#171464) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Lisa Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-11-24T20:51:14Z","message":"[OAS] Migrate connector APIs to v3.1.0 (elastic#171464)","sha":"14886bf8b8a1629535e9b3ce0d6a6485b98299e5","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","docs","Feature:Actions/ConnectorsManagement","backport:prev-minor","v8.12.0"],"number":171464,"url":"https://github.com/elastic/kibana/pull/171464","mergeCommit":{"message":"[OAS] Migrate connector APIs to v3.1.0 (elastic#171464)","sha":"14886bf8b8a1629535e9b3ce0d6a6485b98299e5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/171464","number":171464,"mergeCommit":{"message":"[OAS] Migrate connector APIs to v3.1.0 (elastic#171464)","sha":"14886bf8b8a1629535e9b3ce0d6a6485b98299e5"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
docs
Feature:Actions/ConnectorsManagement
Issues related to Connectors Management UX
release_note:skip
Skip the PR/issue when compiling release notes
Team:ResponseOps
Label for the ResponseOps team (formerly the Cases and Alerting teams)
v8.11.2
v8.12.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the openAPI specification from 3.0.1 to 3.1.0 for the connector APIs. The changes are based on https://www.openapis.org/blog/2021/02/16/migrating-from-openapi-3-0-to-3-1-0
In particular, occurrences of
nullable: true
are replaced andexample:
is replaced byexamples:
.