Append serverless project ID to Support URL #171448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
force-pushed
the
serverless/support-link-add-deployment-id
branch
from
42369ab to
199c86b
Compare
tsullivan
added
Team:SharedUX
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
pgayvallet
approved these changes
Nov 21, 2023
Comment on lines
106
to
113
| let supportUrl = ELASTIC_SUPPORT_LINK; | ||
| if (this.config.serverless?.project_id) { | ||
| // serverless projects use config.id and config.serverless.project_id | ||
| supportUrl += '?serverless_project_id=' + this.config.serverless.project_id; | ||
| } else if (this.config.id) { | ||
| // non-serverless Cloud projects only use config.id | ||
| supportUrl += '?cloud_deployment_id=' + this.config.id; | ||
| } |
There was a problem hiding this comment.
NIT: I would extract that to an getSupportUrl(config: CloudConfigType): string helper function
|
💯 |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Page load bundle
History
To update your PR or re-run it, just comment with: cc @tsullivan |
kibanamachine
added
v8.12.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the URL to the Elastic Support Portal registered by the Cloud plugin, to include the configured deployment ID as a querystring parameter.
?serverless_project_id=123ABC?cloud_deployment_id=123ABCWhere this link can be found in the UI:
