Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Modifying the login method #171383

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

MadameSheema
Copy link
Member

@MadameSheema MadameSheema commented Nov 16, 2023

Summary

rootRequest already includes authentication. In this PR we are modifying the login method to perform a regular cypress call in order to avoid doing this duplicated authentication with the aim of minimising future issues and flakiness.

@MadameSheema MadameSheema changed the title modifying the login method [Security Solution] Modifying the login method Nov 20, 2023
@MadameSheema MadameSheema self-assigned this Nov 20, 2023
@MadameSheema MadameSheema added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.12.0 labels Nov 20, 2023
@MadameSheema MadameSheema marked this pull request as ready for review November 20, 2023 10:32
@MadameSheema MadameSheema requested a review from a team as a code owner November 20, 2023 10:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Investigations - Security Solution Cypress Tests #3 / Timelines Toggle create timeline from plus icon Privileges: READ should not be able to create/update timeline should not be able to create/update timeline

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @MadameSheema

@MadameSheema MadameSheema merged commit 3bb16c7 into elastic:main Nov 21, 2023
@MadameSheema MadameSheema deleted the green-execution branch November 21, 2023 07:08
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants