Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] hide remote es output in serverless #171378

Merged
merged 5 commits into from
Nov 20, 2023
Merged

[Fleet] hide remote es output in serverless #171378

merged 5 commits into from
Nov 20, 2023

Conversation

juliaElastic
Copy link
Contributor

Summary

Relates #104986

Hide Remote Elasticsearch output in serverless from Create/Edit output flyout.

Should we also add validation to prevent creating it in API?

Verified locally by starting kibana in serverless mode:
image

Checklist

@juliaElastic juliaElastic added the release_note:skip Skip the PR/issue when compiling release notes label Nov 16, 2023
@juliaElastic juliaElastic self-assigned this Nov 16, 2023
@juliaElastic juliaElastic requested a review from a team as a code owner November 16, 2023 09:41
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Nov 16, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@nchaulet nchaulet self-requested a review November 16, 2023 14:17
@nchaulet
Copy link
Member

Should we also add validation to prevent creating it in API?

We could, I am curious what happen if we add a remote non serverless ES output it will work no?

nchaulet
nchaulet reviewed Nov 16, 2023
View reviewed changes
...ns/fleet/public/applications/fleet/sections/settings/components/edit_output_flyout/index.tsx Outdated
@@ -87,10 +87,12 @@ export const EditOutputFlyout: React.FunctionComponent<EditOutputFlyoutProps> =
const { kafkaOutput: isKafkaOutputEnabled, remoteESOutput: isRemoteESOutputEnabled } =
ExperimentalFeaturesService.get();
const isRemoteESOutput = inputs.typeInput.value === outputType.RemoteElasticsearch;
// Remote ES output not yet supported in serverless
const isTraditionalBuildFlavor = useKibanaBuildFlavor() === 'traditional';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also use cloudSetup.isServerlessEnabled to check if it's serverless, I am wondering if there is one that is better than the other, and we should probably stick to one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh right, I forgot about that, it is simpler to use that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@juliaElastic
Copy link
Contributor Author

Should we also add validation to prevent creating it in API?

We could, I am curious what happen if we add a remote non serverless ES output it will work no?

I haven't tested it, and we might have some issues that we haven't thought about, so probably better to restrict.

@juliaElastic juliaElastic force-pushed the hide-remote-es-serverless branch from 8a2641f to b3a49c7 Compare November 16, 2023 15:40
nchaulet
nchaulet approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@juliaElastic
Copy link
Contributor Author

Added the API validation for serverless, will add some tests on it next week.

@juliaElastic juliaElastic enabled auto-merge (squash) November 20, 2023 09:39
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #10 / Discover alerting Search source Alert should display actual data view state after update on clicking viewInApp link
  • [job] [logs] FTR Configs #35 / endpoint For each artifact list under management When on the Host isolation exceptions entries list should be able to update an existing Host isolation exceptions entry
  • [job] [logs] x-pack/test_serverless/functional/test_suites/observability/config.ts / serverless observability UI Rules list should create an ES Query Rule and display it when consumer is observability

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.2MB 1.2MB +47.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @juliaElastic

@juliaElastic
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/docs

1 similar comment
@juliaElastic
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/docs

@juliaElastic juliaElastic merged commit 6e46756 into elastic:main Nov 20, 2023
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nchaulet nchaulet nchaulet approved these changes

Assignees

@juliaElastic juliaElastic

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@juliaElastic @elasticmachine @apmmachine @nchaulet @kibana-ci @kibanamachine