Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cases] Custom Fields as Cases Filters #171176
[Cases] Custom Fields as Cases Filters #171176
Changes from all commits
cf63dac
4b5371f
7b86adc
ad0cea3
c9c9555
252e0b1
3a48a2f
8b7c774
ca2c4a4
1f5df78
d84f402
b5cc9b1
e8bc6b9
3fd75c4
5f58c3d
1e426f3
3c5c108
36615d0
b8df42d
c98f2bb
a3ac59b
21d2137
88a4e04
c915c16
1d74669
4f7c987
7f6bc68
6181709
24d6e79
177f26c
68d7731
c746466
ff764d0
4ac9a16
4b26020
8b1f351
6b5f78b
11a8ee2
4d439b6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got an ts error here https://github.com/elastic/kibana/pull/171176/files#diff-5ce927c2e523c85bb1853fd933c3469c1881f69eef57ff75be97e622b18621a0R54. Looks like changing this does not break anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me. Unrelated to the type change, what about
wrapper: appMockRender.AppWrapper
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried but it returns another ts error
Any idea what it means?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new feature as the "more" button doesn't seem to be showing this info