Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.11] [EDR Workflows] Verify flaky osquery tests (#169749) #170930

Merged
merged 7 commits into from
Nov 14, 2023

Conversation

tomsonpl
Copy link
Contributor

@tomsonpl tomsonpl commented Nov 9, 2023

(cherry picked from commit a15a948)

# Conflicts:
#	.buildkite/scripts/lifecycle/post_command.sh
#	x-pack/plugins/osquery/cypress/e2e/all/alerts_automated_action_results.cy.ts
#	x-pack/plugins/osquery/cypress/e2e/all/alerts_response_actions_form.cy.ts
#	x-pack/plugins/osquery/cypress/e2e/all/packs_integration.cy.ts
#	x-pack/plugins/osquery/cypress/support/e2e.ts
@tomsonpl tomsonpl self-assigned this Nov 9, 2023
@kibana-ci
Copy link
Collaborator

kibana-ci commented Nov 9, 2023

💔 Build Failed

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
osquery 1.0MB 1.0MB +479.0B
securitySolution 13.0MB 13.0MB +156.0B
total +635.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tomsonpl

Copy link
Member

@ashokaditya ashokaditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern is tracking these changes later if we need to debug. I would suggest we add a 8.11 label to the corresponding PRs that this PR assimilates changes from for posterity. And link this PR on each of those.

Another way to go about it is create 8.11 backports for each PR that is listed in this PR's summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants