-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(slo): add events chart #170896
feat(slo): add events chart #170896
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
2b50555
to
4408af9
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @kdelemme |
@@ -0,0 +1,3 @@ | |||
# @kbn/calculate-auto | |||
|
|||
Empty package generated by @kbn/generate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kdelemme Maybe a few words about what the package does?
At a quick glance it looks good! I will test it locally as well |
@kdelemme Nice! I generated some good and bad events and looks good! I like how hovering on the new chart displays error budget remaining and sli value on the above charts. I just noticed that in the Error budget burn down and Historical SLI charts the last timestamp is 17:00, but the good vs bad events last timestamp is 20:50. Did you notice something similar? Screen.Recording.2023-11-16.at.20.57.31.mov |
Resolves #170888
Summary
This PR adds a new chart on the SLO details page showing the good vs bad events over the last 24hours.
Timeslice Metric SLOs don't have this chart for the moment.
This PR changes the getPreviewData internal API to handle any arbitrary range
{ start, end }
for computing the preview data with.calculateAuto
is used to automatically set the interval to get about 100 buckets.I've moved the calculateAuto helper function into it's own package. In another PR, I'll remove the duplicated calculateAuto libraries from other plugins.