Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slo): add events chart #170896

Merged
merged 7 commits into from
Nov 16, 2023
Merged

Conversation

kdelemme
Copy link
Contributor

@kdelemme kdelemme commented Nov 8, 2023

Resolves #170888

Summary

This PR adds a new chart on the SLO details page showing the good vs bad events over the last 24hours.
Timeslice Metric SLOs don't have this chart for the moment.

This PR changes the getPreviewData internal API to handle any arbitrary range { start, end } for computing the preview data with. calculateAuto is used to automatically set the interval to get about 100 buckets.
I've moved the calculateAuto helper function into it's own package. In another PR, I'll remove the duplicated calculateAuto libraries from other plugins.

Screenshots
image
image

@kdelemme kdelemme self-assigned this Nov 8, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kdelemme kdelemme added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.12.0 Team:obs-ux-management Observability Management User Experience Team release_note:skip Skip the PR/issue when compiling release notes and removed Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" labels Nov 8, 2023
@kdelemme kdelemme marked this pull request as ready for review November 8, 2023 17:13
@kdelemme kdelemme requested a review from a team as a code owner November 8, 2023 17:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@kdelemme kdelemme force-pushed the slo/add-events-chart branch from 2b50555 to 4408af9 Compare November 9, 2023 16:56
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Serverless Security Cypress Tests #4 / Use Value list in exception entry Should use value list in exception entry, and validate deleting value list prompt Should use value list in exception entry, and validate deleting value list prompt

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 490 491 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/calculate-auto - 10 +10

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 1.1MB 1.1MB +3.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 104.1KB 104.2KB +80.0B
Unknown metric groups

API count

id before after diff
@kbn/calculate-auto - 10 +10

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kdelemme

@mgiota mgiota self-requested a review November 15, 2023 13:42
@@ -0,0 +1,3 @@
# @kbn/calculate-auto

Empty package generated by @kbn/generate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kdelemme Maybe a few words about what the package does?

@mgiota
Copy link
Contributor

mgiota commented Nov 15, 2023

At a quick glance it looks good! I will test it locally as well

@simianhacker simianhacker self-requested a review November 15, 2023 21:14
@mgiota
Copy link
Contributor

mgiota commented Nov 16, 2023

@kdelemme Nice! I generated some good and bad events and looks good! I like how hovering on the new chart displays error budget remaining and sli value on the above charts. I just noticed that in the Error budget burn down and Historical SLI charts the last timestamp is 17:00, but the good vs bad events last timestamp is 20:50. Did you notice something similar?

Screen.Recording.2023-11-16.at.20.57.31.mov

@mgiota
Copy link
Contributor

mgiota commented Nov 16, 2023

I refreshed now the page (or it auto refreshed) and now all charts are in sync!
Screenshot 2023-11-16 at 21 05 06

@kdelemme kdelemme merged commit 7398fe9 into elastic:main Nov 16, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 16, 2023
@kdelemme kdelemme deleted the slo/add-events-chart branch November 16, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SLO] Good/Bad Events Chart on SLO details page
6 participants