[Advanced Settings] Fix defaultIndex setting's default value #170865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElenaStoeva
added
Feature:Kibana Management
|
/ci |
|
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @ElenaStoeva |
|
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
mattkime
approved these changes
Dec 8, 2023
ElenaStoeva
added
backport:prev-minor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 11, 2023
…#170865) Fixes elastic#168732 ## Summary This PR changes the default value of the `defaultIndex` setting to an empty string. Previously, the default value was set to `null` and this was causing a wrong behaviour in the Advanced Settings UI as it expects a string value for the settings of type `string`. **Before - the "Reset to default" link did not clear the user value:** https://github.com/elastic/kibana/assets/59341489/2c47306b-feac-4e08-bbae-3db7b0a3e5fd **With these changes:** https://github.com/elastic/kibana/assets/59341489/dc46caa8-9860-4b66-87ca-9c184c5a8391 (cherry picked from commit 946b38e)
ElenaStoeva
deleted the
advanced-settings/fix-default-data-view-setting-value
branch
kibanamachine
added a commit
that referenced
this pull request
Dec 11, 2023
…170865) (#173027) # Backport This will backport the following commits from `main` to `8.12`: - [[Advanced Settings] Fix defaultIndex setting's default value (#170865)](#170865) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Elena Stoeva","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-11T10:01:01Z","message":"[Advanced Settings] Fix defaultIndex setting's default value (#170865)\n\nFixes https://github.com/elastic/kibana/issues/168732\r\n\r\n## Summary\r\n\r\nThis PR changes the default value of the `defaultIndex` setting to an\r\nempty string. Previously, the default value was set to `null` and this\r\nwas causing a wrong behaviour in the Advanced Settings UI as it expects\r\na string value for the settings of type `string`.\r\n\r\n**Before - the \"Reset to default\" link did not clear the user value:**\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/59341489/2c47306b-feac-4e08-bbae-3db7b0a3e5fd\r\n\r\n\r\n**With these changes:**\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/59341489/dc46caa8-9860-4b66-87ca-9c184c5a8391","sha":"946b38ed577ddfccf1fb022d7fa1ff6e9cdd1606","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Kibana Management","Team:Deployment Management","release_note:skip","backport:prev-minor","v8.12.0","v8.13.0"],"number":170865,"url":"https://github.com/elastic/kibana/pull/170865","mergeCommit":{"message":"[Advanced Settings] Fix defaultIndex setting's default value (#170865)\n\nFixes https://github.com/elastic/kibana/issues/168732\r\n\r\n## Summary\r\n\r\nThis PR changes the default value of the `defaultIndex` setting to an\r\nempty string. Previously, the default value was set to `null` and this\r\nwas causing a wrong behaviour in the Advanced Settings UI as it expects\r\na string value for the settings of type `string`.\r\n\r\n**Before - the \"Reset to default\" link did not clear the user value:**\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/59341489/2c47306b-feac-4e08-bbae-3db7b0a3e5fd\r\n\r\n\r\n**With these changes:**\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/59341489/dc46caa8-9860-4b66-87ca-9c184c5a8391","sha":"946b38ed577ddfccf1fb022d7fa1ff6e9cdd1606"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/170865","number":170865,"mergeCommit":{"message":"[Advanced Settings] Fix defaultIndex setting's default value (#170865)\n\nFixes https://github.com/elastic/kibana/issues/168732\r\n\r\n## Summary\r\n\r\nThis PR changes the default value of the `defaultIndex` setting to an\r\nempty string. Previously, the default value was set to `null` and this\r\nwas causing a wrong behaviour in the Advanced Settings UI as it expects\r\na string value for the settings of type `string`.\r\n\r\n**Before - the \"Reset to default\" link did not clear the user value:**\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/59341489/2c47306b-feac-4e08-bbae-3db7b0a3e5fd\r\n\r\n\r\n**With these changes:**\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/59341489/dc46caa8-9860-4b66-87ca-9c184c5a8391","sha":"946b38ed577ddfccf1fb022d7fa1ff6e9cdd1606"}}]}] BACKPORT--> Co-authored-by: Elena Stoeva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #168732
Summary
This PR changes the default value of the
defaultIndexsetting to an empty string. Previously, the default value was set tonulland this was causing a wrong behaviour in the Advanced Settings UI as it expects a string value for the settings of typestring.Before - the "Reset to default" link did not clear the user value:
Screen.Recording.2023-12-08.at.16.08.51.mov
With these changes:
Screen.Recording.2023-12-08.at.16.07.07.mov