Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Detection engine] fix deduplication ES|QL test #170772

Merged
merged 8 commits into from
Nov 14, 2023
Merged

[Security Solution][Detection engine] fix deduplication ES|QL test #170772

merged 8 commits into from
Nov 14, 2023

Conversation

vitaliidm
Copy link
Contributor

Summary

@vitaliidm vitaliidm self-assigned this Nov 7, 2023
@vitaliidm vitaliidm added release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Engine Security Solution Detection Engine Area v8.12.0 labels Nov 7, 2023
@vitaliidm
Copy link
Contributor Author

flaky tests runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3934

@vitaliidm vitaliidm marked this pull request as ready for review November 8, 2023 08:58
@vitaliidm vitaliidm requested a review from a team as a code owner November 8, 2023 08:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@vitaliidm vitaliidm requested review from a team and dhurley14 and removed request for dhurley14 November 8, 2023 10:16
@vitaliidm vitaliidm marked this pull request as draft November 14, 2023 09:26
@vitaliidm vitaliidm marked this pull request as ready for review November 14, 2023 09:26
e40pud
e40pud approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@e40pud e40pud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

x-pack/test/detection_engine_api_integration/security_and_spaces/rule_execution_logic/esql.ts Outdated Show resolved Hide resolved
@vitaliidm @e40pud
Update x-pack/test/detection_engine_api_integration/security_and_spac…
e26f561 
…es/rule_execution_logic/esql.ts

Co-authored-by: Ievgen Sorokopud <[email protected]>
@vitaliidm vitaliidm enabled auto-merge (squash) November 14, 2023 10:30
@vitaliidm vitaliidm merged commit e4a039b into elastic:main Nov 14, 2023
26 checks passed
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #23 / analytics instrumented events from the server core-overall_status_changed "before all" hook for "should emit the initial "degraded" event with the context set to initializing"

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @vitaliidm

@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 14, 2023
@logeekal logeekal mentioned this pull request Nov 16, 2023
Closed
@vitaliidm vitaliidm deleted the de-8-12/fix-esql-test branch March 4, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e40pud e40pud e40pud approved these changes

Assignees

@vitaliidm vitaliidm

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vitaliidm @elasticmachine @kibana-ci @e40pud @kibanamachine