[Security Solution] make copytoclipboard component more generic #170700
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When we created the
CopyToClipboard
a few months ago, it was used only in one place, for theShare alert
functionality in the flyout's header.A few weeks ago we used it for the new Json tab. Both UI were similar enough at the time, so only a minor refactor of the component was necessary to support both cases.
Since then the
Share alert
button has been changed to a single icon (no text). If we still want to use the same shared component, we need it to support bothEuiButtonIcon
andEuiButtonEmpty
as the render is slightly different between the 2 (EuiButtonEmpty
has some weird internal padding between the icon and the text, which means that the icon isn't centered when there isn't any text displayed).This PR redesigns the
CopyToClipboard
, instead of having it handle multiple renders, it's easier and more flexibile to have the component do the copy functionality only, and let the parent component decide what needs to be rendered.Checklist