Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OAS] Fix cases API data types for comments #170698

Merged
merged 4 commits into from
Nov 8, 2023
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Nov 6, 2023

Summary

Fixes #160732

@lcawl lcawl added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) docs Feature:Cases Cases feature backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) v8.12.0 v8.11.1 labels Nov 6, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl marked this pull request as ready for review November 7, 2023 17:39
@lcawl lcawl requested a review from a team as a code owner November 7, 2023 17:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@lcawl lcawl merged commit bb15bb1 into elastic:main Nov 8, 2023
@lcawl lcawl deleted the case-oas-types branch November 8, 2023 15:13
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 8, 2023
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 8, 2023
# Backport

This will backport the following commits from `main` to `8.11`:
- [[OAS] Fix cases API data types for comments
(#170698)](#170698)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-11-08T15:12:54Z","message":"[OAS]
Fix cases API data types for comments
(#170698)","sha":"bb15bb14482ad2ebad232a53678f7be64c1eb7eb","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","docs","Feature:Cases","backport:prev-minor","v8.12.0","v8.11.1"],"number":170698,"url":"https://github.com/elastic/kibana/pull/170698","mergeCommit":{"message":"[OAS]
Fix cases API data types for comments
(#170698)","sha":"bb15bb14482ad2ebad232a53678f7be64c1eb7eb"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/170698","number":170698,"mergeCommit":{"message":"[OAS]
Fix cases API data types for comments
(#170698)","sha":"bb15bb14482ad2ebad232a53678f7be64c1eb7eb"}},{"branch":"8.11","label":"v8.11.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Lisa Cawley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) docs Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.11.1 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OAS] Fix cases API data types
6 participants