[ML] Creates categorization job from pattern analysis #170567

jgowdyelastic · 2023-11-03T19:24:52Z

Adds the ability to quickly create a categorisation anomaly detection job from the pattern analysis flyout.
Adds a new created_by ID categorization-wizard-from-pattern-analysis which can be picked up by telemetry.

Creates a new package for sharing our AIOPs ui actions IDs. I think we should move the pattern analysis ID to this package too, but that can be done in a separate PR.

2023-11-09.17-13-03.2023-11-09.17_13_54.mp4

2023-11-09.17-27-29.2023-11-09.17_28_10.mp4

…fix'

elasticmachine · 2023-11-13T13:46:39Z

Pinging @elastic/ml-ui (:ml)

x-pack/plugins/ml/public/embeddables/job_creation/aiops/flyout/create_job.tsx

peteharverson

Tested and overall looks good. Just one question mark around adding an influencer for per-partition jobs.

x-pack/plugins/ml/public/application/jobs/new_job/job_from_pattern_analysis/quick_create_job.ts

peteharverson

Tested latest changes and LGTM

alvarezmelissa87 · 2023-11-15T17:27:06Z

x-pack/plugins/aiops/public/components/log_categorization/create_categorization_job.tsx

+    <>
+      <EuiButtonEmpty
+        data-test-subj="aiopsLogCategorizationFlyoutAdJobButton"
+        onClick={() => createADJob()}


Can't you just pass in createADJob here without creating a wrapper function?

Updated in d32017d

alvarezmelissa87 · 2023-11-15T17:54:24Z

x-pack/plugins/ml/public/application/jobs/new_job/job_from_pattern_analysis/route_resolver.ts

+  try {
+    categorizationType = rison.decode(categorizationTypeRisonString) as CategorizationType;
+  } catch (error) {
+    categorizationType = CATEGORIZATION_TYPE.COUNT;


Seems like there's a pattern of catching and setting the value to an empty string - maybe it would be good to have a small util function that abstracts that?

Good point, these can be cleaned up quite a lot.
Updated in d32017d
I've also changed the maps and lens versions of this file.

alvarezmelissa87 · 2023-11-15T18:14:37Z

x-pack/plugins/ml/public/application/jobs/new_job/job_from_pattern_analysis/utils.ts

+) {
+  const locator = share.url.locators.get(ML_APP_LOCATOR);
+
+  const url = await locator?.getUrl({


Does there need to be a contingency for when locator is undefined? So the url doesn't end up as undefined?

I think it's safe to assume that locator will alway be defined as we're in the ML app. We do this in other places.
I've updated the code to assert that locator is defined.
Updated in d32017d and 055a53b

alvarezmelissa87

Left a few comments but overall LGTM
Giving it the green checkmark to unblock

jgowdyelastic · 2023-11-21T10:01:37Z

@elasticmachine merge upstream

jgowdyelastic · 2023-11-21T10:05:55Z

@elasticmachine merge upstream

kibanamachine · 2023-11-21T10:05:57Z

expected head sha didn’t match current head ref.

…-job-from-pattern-analysis

…hub.com:jgowdyelastic/kibana into create-categorization-job-from-pattern-analysis

kibana-ci · 2023-11-21T14:17:12Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 791a0d6

Failed CI Steps

Security Solution Cypress Tests #3

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`aiops`	416	419	+3
`ml`	1846	1859	+13
total			+16

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/ml-ui-actions`	-	7	+7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`aiops`	375.8KB	376.5KB	+751.0B
`ml`	3.6MB	3.6MB	+19.3KB
total			+20.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`ml`	78.6KB	78.7KB	+148.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/ml-ui-actions`	-	7	+7
`aiops`	69	70	+1
total			+8

async chunk count

id	before	after	diff
`ml`	35	36	+1

ESLint disabled line counts

id	before	after	diff
`ml`	557	559	+2

Total ESLint disabled count

id	before	after	diff
`ml`	560	562	+2

History

💔 Build #177228 failed aa2cf7c
💛 Build #176507 was flaky 055a53b
💚 Build #176456 succeeded 3fddf0b
💚 Build #175710 succeeded 1afac7e
💔 Build #175326 failed 7802419

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

jgowdyelastic added 10 commits November 3, 2023 19:24

[ML] Create categorization job from pattern analysis

fc7bb19

Merge branch 'main' into create-categorization-job-from-pattern-analysis

1425e01

Merge branch 'main' into create-categorization-job-from-pattern-analysis

7872002

Merge branch 'main' into create-categorization-job-from-pattern-analysis

00f5a00

adding link to wizard

53e10c5

fixing per partition

8fc8697

Merge branch 'main' into create-categorization-job-from-pattern-analysis

080643a

better validation

ebfe734

fix dependency cache issue

7c0cf71

passing stop on warn to wizard

f48b6c3

jgowdyelastic mentioned this pull request Nov 8, 2023

[ML] Kibana context types clean up #170868

Merged

jgowdyelastic and others added 19 commits November 8, 2023 16:42

types refactor

54017c1

making uiActions optional

ff2f4e9

moving button to sepatate component

073000e

moving ui action to package

408d464

Merge branch 'main' into create-categorization-job-from-pattern-analysis

8625443

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

fd08c9a

…fix'

[CI] Auto-commit changed files from 'node scripts/lint_packages --fix'

f99fe22

[CI] Auto-commit changed files from 'node scripts/generate codeowners'

f9e718f

Merge branch 'main' into create-categorization-job-from-pattern-analysis

dacbecb

translations

3d8b6f3

Add machine learning icon

583f366

flyout refactor

4cb5543

using correct time range for results

bfa89a9

Merge branch 'main' into create-categorization-job-from-pattern-analysis

156b2df

private methods

4c97a64

Merge branch 'main' into create-categorization-job-from-pattern-analysis

9142c26

optional dashboard

ce5a26d

clean up

31b87c1

adjusting gutter size

f5d3f76

jgowdyelastic added :ml Feature:Anomaly Detection ML anomaly detection release_note:feature Makes this part of the condensed release notes v8.12.0 labels Nov 13, 2023

jgowdyelastic marked this pull request as ready for review November 13, 2023 13:46

jgowdyelastic requested a review from a team as a code owner November 13, 2023 13:46

Merge branch 'main' into create-categorization-job-from-pattern-analysis

7802419

peteharverson reviewed Nov 14, 2023

View reviewed changes

x-pack/plugins/ml/public/embeddables/job_creation/aiops/flyout/create_job.tsx Outdated Show resolved Hide resolved

peteharverson reviewed Nov 14, 2023

View reviewed changes

x-pack/plugins/ml/public/application/jobs/new_job/job_from_pattern_analysis/quick_create_job.ts Show resolved Hide resolved

adding partition field to influencers

1afac7e

peteharverson approved these changes Nov 14, 2023

View reviewed changes

alvarezmelissa87 reviewed Nov 15, 2023

View reviewed changes

alvarezmelissa87 approved these changes Nov 15, 2023

View reviewed changes

jgowdyelastic added 3 commits November 16, 2023 10:09

Merge branch 'main' into create-categorization-job-from-pattern-analysis

3fddf0b

improving rison parsing

d32017d

removing question mark

055a53b

Merge branch 'main' into create-categorization-job-from-pattern-analysis

7eaabbd

jgowdyelastic added 3 commits November 21, 2023 10:49

Merge remote-tracking branch 'origin/main' into create-categorization…

8451388

…-job-from-pattern-analysis

Merge branch 'create-categorization-job-from-pattern-analysis' of git…

aa2cf7c

…hub.com:jgowdyelastic/kibana into create-categorization-job-from-pattern-analysis

Merge branch 'main' into create-categorization-job-from-pattern-analysis

791a0d6

jgowdyelastic merged commit 5e3b124 into elastic:main Nov 21, 2023

kibanamachine added the backport:skip This commit does not require backporting label Nov 21, 2023

szabosteve changed the title ~~[ML] Create categorization job from pattern analysis~~ [ML] Creates categorization job from pattern analysis Dec 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] Creates categorization job from pattern analysis #170567

[ML] Creates categorization job from pattern analysis #170567

jgowdyelastic commented Nov 3, 2023 •

edited

Loading

elasticmachine commented Nov 13, 2023

peteharverson left a comment

peteharverson left a comment

alvarezmelissa87 Nov 15, 2023

jgowdyelastic Nov 16, 2023

alvarezmelissa87 Nov 15, 2023

jgowdyelastic Nov 16, 2023

alvarezmelissa87 Nov 15, 2023

jgowdyelastic Nov 16, 2023 •

edited

Loading

alvarezmelissa87 left a comment

jgowdyelastic commented Nov 21, 2023

jgowdyelastic commented Nov 21, 2023

kibanamachine commented Nov 21, 2023

kibana-ci commented Nov 21, 2023

API count

async chunk count

ESLint disabled line counts

Total ESLint disabled count

[ML] Creates categorization job from pattern analysis #170567

[ML] Creates categorization job from pattern analysis #170567

Conversation

jgowdyelastic commented Nov 3, 2023 • edited Loading

elasticmachine commented Nov 13, 2023

peteharverson left a comment

Choose a reason for hiding this comment

peteharverson left a comment

Choose a reason for hiding this comment

alvarezmelissa87 Nov 15, 2023

Choose a reason for hiding this comment

jgowdyelastic Nov 16, 2023

Choose a reason for hiding this comment

alvarezmelissa87 Nov 15, 2023

Choose a reason for hiding this comment

jgowdyelastic Nov 16, 2023

Choose a reason for hiding this comment

alvarezmelissa87 Nov 15, 2023

Choose a reason for hiding this comment

jgowdyelastic Nov 16, 2023 • edited Loading

Choose a reason for hiding this comment

alvarezmelissa87 left a comment

Choose a reason for hiding this comment

jgowdyelastic commented Nov 21, 2023

jgowdyelastic commented Nov 21, 2023

kibanamachine commented Nov 21, 2023

kibana-ci commented Nov 21, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

async chunk count

ESLint disabled line counts

Total ESLint disabled count

History

jgowdyelastic commented Nov 3, 2023 •

edited

Loading

jgowdyelastic Nov 16, 2023 •

edited

Loading