Removes duplicated RedirectAppLinks component
#170304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eokoneyo
added
release_note:skip
|
Documentation preview: |
eokoneyo
force-pushed
the
remove-dedupe-redirect-link-component
branch
from
9505b39 to
cc4afd6
Compare
2 tasks
eokoneyo
force-pushed
the
remove-dedupe-redirect-link-component
branch
6 times, most recently
from
a921aca to
86ac142
Compare
eokoneyo
commented
Nov 3, 2023
| @@ -9,6 +9,9 @@ | |||
| import { css } from '@emotion/react'; | |||
|
|
|||
| export const redirectAppLinksStyles = css({ | |||
| display: 'flex', | |||
| display: 'inherit', | |||
There was a problem hiding this comment.
This change makes the redirect app link inherit the display property of it's parent element, ideally this component should not have a presentational effect because it only handles links but for historical reasons and how markup has been built around this component we'd have to support this.
The flex properties added are necessary to support existing markup that also expects that the .KbnAppWrapper class would be present on the RedirectAppLinks component, given that this component historically also accepted classNames.
eokoneyo
force-pushed
the
remove-dedupe-redirect-link-component
branch
2 times, most recently
from
b171731 to
c1464ad
Compare
💔 Build Failed
Failed CI Steps
Test Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled in files
ESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @eokoneyo |
eokoneyo
force-pushed
the
remove-dedupe-redirect-link-component
branch
2 times, most recently
from
1669bd1 to
fd88f12
Compare
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
… in varying situations account for child element with display block property
eokoneyo
force-pushed
the
remove-dedupe-redirect-link-component
branch
from
450b926 to
a6f8ecc
Compare
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled in files
ESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @eokoneyo |
yngrdyn
approved these changes
Nov 10, 2023
yuliacech
approved these changes
Nov 10, 2023
kibanamachine
added
v8.12.0
backport:skip
eokoneyo
added a commit
that referenced
this pull request
Nov 14, 2023
## Summary <!-- Summarize your PR. If it involves visual changes include a screenshot or gif. --> This is a follow up to #170304, it resolves the issue with the navigation breadcrumbs in serverless; explicitly setting height to `100%` causes an issue where when the `RedirectAppLink` component is a child of a parent container with a display property of `flex` with `align-items` set to `center`, content which one would expect to be center aligned is not and this makes sense because the value of align-items [applies to it's direct children as a group](https://developer.mozilla.org/en-US/docs/Web/CSS/align-items). To resolve the issue this PR removes the declaration that explicitly sets a height value to 100% but rather make the component inherit the height of it's parent, this style is kept for historical reasons (see #141656) despite the fact that the `RedirectAppLinks` component is not a presentational component. <!-- ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the duplicated RedirectAppLinks component which has been marked as deprecated since 74a00fa.
All references to the previous import declaration from
@kbn/kibana-react-plugin/publichave been replaced with@kbn/shared-ux-link-redirect-app, this change ensures that the current app behaviour is preserved, and changes to match the expectation of the new component have been applied where necessary.Changes relating to the new
RedirectAppLinkscomponent;classNameanymore as it is not a presentational component despite it being used as one previously, there's change to make accommodation for how it had been used.data-test-subjattribute with the valuekbnRedirectAppLinkon the dom node that wraps it's children.Checklist