Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[security_page] improve force logout #170227

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

dmlemeshko
Copy link
Member

@dmlemeshko dmlemeshko commented Oct 31, 2023

Summary

Addressing forceLogout flakiness https://buildkite.com/elastic/appex-qa-serverless-kibana-ftr-tests/builds/370

Error: timed out waiting for Waiting for logout to complete
    at onFailure (retry_for_truthy.ts:39:13)
    at retryForSuccess (retry_for_success.ts:59:13)
    at retryForTruthy (retry_for_truthy.ts:27:3)
    at RetryService.waitFor (retry.ts:59:5)
    at SecurityPageObject.forceLogout (security_page.ts:319:7)
    at Object.forceLogout (svl_common_page.ts:95:7)
    at Context. (view_case.ts:44:7)
    at Object.apply (wrap_function.js:73:16)
image

Flaky-test-runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3839 200/200

@dmlemeshko dmlemeshko added v8.12.0 v8.11.1 v8.10.5 release_note:skip Skip the PR/issue when compiling release notes labels Oct 31, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dmlemeshko dmlemeshko marked this pull request as ready for review October 31, 2023 16:58
@dmlemeshko dmlemeshko requested a review from pheyos October 31, 2023 17:01
@dmlemeshko dmlemeshko enabled auto-merge (squash) November 1, 2023 11:44
@dmlemeshko dmlemeshko removed the v8.10.5 label Nov 1, 2023
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmlemeshko dmlemeshko merged commit f21e31a into elastic:main Nov 1, 2023
8 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 1, 2023
## Summary

Addressing `forceLogout` flakiness
https://buildkite.com/elastic/appex-qa-serverless-kibana-ftr-tests/builds/370

```
Error: timed out waiting for Waiting for logout to complete
    at onFailure (retry_for_truthy.ts:39:13)
    at retryForSuccess (retry_for_success.ts:59:13)
    at retryForTruthy (retry_for_truthy.ts:27:3)
    at RetryService.waitFor (retry.ts:59:5)
    at SecurityPageObject.forceLogout (security_page.ts:319:7)
    at Object.forceLogout (svl_common_page.ts:95:7)
    at Context. (view_case.ts:44:7)
    at Object.apply (wrap_function.js:73:16)
```

<img width="1294" alt="image"
src="https://github.com/elastic/kibana/assets/10977896/92ff13da-2c80-4eb7-8b3e-63779fb61075">

Flaky-test-runner:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3839
200/200

(cherry picked from commit f21e31a)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 1, 2023
# Backport

This will backport the following commits from `main` to `8.11`:
- [[security_page] improve force logout
(#170227)](#170227)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dzmitry
Lemechko","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-11-01T13:45:32Z","message":"[security_page]
improve force logout (#170227)\n\n## Summary\r\n\r\nAddressing
`forceLogout`
flakiness\r\nhttps://buildkite.com/elastic/appex-qa-serverless-kibana-ftr-tests/builds/370\r\n\r\n```\r\nError:
timed out waiting for Waiting for logout to complete\r\n at onFailure
(retry_for_truthy.ts:39:13)\r\n at retryForSuccess
(retry_for_success.ts:59:13)\r\n at retryForTruthy
(retry_for_truthy.ts:27:3)\r\n at RetryService.waitFor
(retry.ts:59:5)\r\n at SecurityPageObject.forceLogout
(security_page.ts:319:7)\r\n at Object.forceLogout
(svl_common_page.ts:95:7)\r\n at Context. (view_case.ts:44:7)\r\n at
Object.apply (wrap_function.js:73:16)\r\n```\r\n\r\n<img width=\"1294\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/10977896/92ff13da-2c80-4eb7-8b3e-63779fb61075\">\r\n\r\n\r\nFlaky-test-runner:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3839\r\n200/200","sha":"f21e31acf26e18e76d32cfafb0cfae83f98bd7f5","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.12.0","v8.11.1"],"number":170227,"url":"https://github.com/elastic/kibana/pull/170227","mergeCommit":{"message":"[security_page]
improve force logout (#170227)\n\n## Summary\r\n\r\nAddressing
`forceLogout`
flakiness\r\nhttps://buildkite.com/elastic/appex-qa-serverless-kibana-ftr-tests/builds/370\r\n\r\n```\r\nError:
timed out waiting for Waiting for logout to complete\r\n at onFailure
(retry_for_truthy.ts:39:13)\r\n at retryForSuccess
(retry_for_success.ts:59:13)\r\n at retryForTruthy
(retry_for_truthy.ts:27:3)\r\n at RetryService.waitFor
(retry.ts:59:5)\r\n at SecurityPageObject.forceLogout
(security_page.ts:319:7)\r\n at Object.forceLogout
(svl_common_page.ts:95:7)\r\n at Context. (view_case.ts:44:7)\r\n at
Object.apply (wrap_function.js:73:16)\r\n```\r\n\r\n<img width=\"1294\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/10977896/92ff13da-2c80-4eb7-8b3e-63779fb61075\">\r\n\r\n\r\nFlaky-test-runner:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3839\r\n200/200","sha":"f21e31acf26e18e76d32cfafb0cfae83f98bd7f5"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/170227","number":170227,"mergeCommit":{"message":"[security_page]
improve force logout (#170227)\n\n## Summary\r\n\r\nAddressing
`forceLogout`
flakiness\r\nhttps://buildkite.com/elastic/appex-qa-serverless-kibana-ftr-tests/builds/370\r\n\r\n```\r\nError:
timed out waiting for Waiting for logout to complete\r\n at onFailure
(retry_for_truthy.ts:39:13)\r\n at retryForSuccess
(retry_for_success.ts:59:13)\r\n at retryForTruthy
(retry_for_truthy.ts:27:3)\r\n at RetryService.waitFor
(retry.ts:59:5)\r\n at SecurityPageObject.forceLogout
(security_page.ts:319:7)\r\n at Object.forceLogout
(svl_common_page.ts:95:7)\r\n at Context. (view_case.ts:44:7)\r\n at
Object.apply (wrap_function.js:73:16)\r\n```\r\n\r\n<img width=\"1294\"
alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/10977896/92ff13da-2c80-4eb7-8b3e-63779fb61075\">\r\n\r\n\r\nFlaky-test-runner:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3839\r\n200/200","sha":"f21e31acf26e18e76d32cfafb0cfae83f98bd7f5"}},{"branch":"8.11","label":"v8.11.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Dzmitry Lemechko <[email protected]>
delanni pushed a commit to delanni/kibana that referenced this pull request Nov 6, 2023
## Summary

Addressing `forceLogout` flakiness
https://buildkite.com/elastic/appex-qa-serverless-kibana-ftr-tests/builds/370

```
Error: timed out waiting for Waiting for logout to complete
    at onFailure (retry_for_truthy.ts:39:13)
    at retryForSuccess (retry_for_success.ts:59:13)
    at retryForTruthy (retry_for_truthy.ts:27:3)
    at RetryService.waitFor (retry.ts:59:5)
    at SecurityPageObject.forceLogout (security_page.ts:319:7)
    at Object.forceLogout (svl_common_page.ts:95:7)
    at Context. (view_case.ts:44:7)
    at Object.apply (wrap_function.js:73:16)
```

<img width="1294" alt="image"
src="https://github.com/elastic/kibana/assets/10977896/92ff13da-2c80-4eb7-8b3e-63779fb61075">


Flaky-test-runner:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3839
200/200
@dmlemeshko dmlemeshko deleted the ftr/improve-logout-wait branch November 21, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v8.11.0 v8.11.1 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants