Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Serverless] Open Security project features modal in Cloud UI #170212

Merged
merged 4 commits into from
Nov 1, 2023
Merged

[Security Solution][Serverless] Open Security project features modal in Cloud UI #170212

merged 4 commits into from
Nov 1, 2023

Conversation

semd
Copy link
Contributor

@semd semd commented Oct 31, 2023

Summary

Use open=securityProjectFeatures query param in the Serverless Get Started page link, to open the project features (tier) modal directly.

openProjectFeatures_query_param.mov

@semd semd added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Explore Project:Serverless Work as part of the Serverless project for its initial release v8.12.0 labels Oct 31, 2023
@semd semd self-assigned this Oct 31, 2023
@semd semd requested a review from a team as a code owner October 31, 2023 10:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@semd semd enabled auto-merge (squash) October 31, 2023 10:08
@semd semd requested a review from YulNaumenko October 31, 2023 10:08
@semd
Copy link
Contributor Author

semd commented Oct 31, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolutionServerless 41.6KB 41.7KB +39.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @semd

YulNaumenko
YulNaumenko approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@semd semd merged commit 148ee6a into elastic:main Nov 1, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 1, 2023
delanni pushed a commit to delanni/kibana that referenced this pull request Nov 6, 2023
@semd @delanni
[Security Solution][Serverless] Open Security project features modal …
5954d04 
…in Cloud UI (elastic#170212)

## Summary

Use `open=securityProjectFeatures` query param in the Serverless _Get
Started_ page link, to open the project features (tier) modal directly.



https://github.com/elastic/kibana/assets/17747913/f00c2092-047d-43ad-a5eb-7996718bd0ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YulNaumenko YulNaumenko YulNaumenko approved these changes

Assignees

@semd semd

Labels
backport:skip This commit does not require backporting Project:Serverless Work as part of the Serverless project for its initial release release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@semd @elasticmachine @kibana-ci @YulNaumenko @kibanamachine