[SecuritySolution] Fix topN legend actions - filter in / out in timeline #170127

angorayc · 2023-10-30T14:10:19Z

Summary

https://github.com/elastic/security-team/issues/7748
#168199
#169656

Screen.Recording.2023-10-30.at.14.43.48.mov

…-fix'

angorayc · 2023-10-30T16:59:06Z

x-pack/plugins/security_solution/public/actions/filter/lens/helpers.ts

+      if (!field) return;
+
+      const timeline = getTimelineById(store.getState(), TimelineId.active);
+      services.topValuesPopover.closePopover();


We have to close topN after applying a filter, as it wouldn't close itself.

michaelolo24

Thank you for making these changes @angorayc !

michaelolo24 · 2023-10-31T00:14:47Z

@elasticmachine merge upstream

…x-topn-filters

elasticmachine · 2023-10-31T15:52:25Z

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

elasticmachine · 2023-10-31T15:52:25Z

Pinging @elastic/security-solution (Team: SecuritySolution)

drewdaemon

Very well done. This is exactly as I imagined it. Code review only.

kibana-ci · 2023-10-31T17:30:08Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 8b6efbe

Failed CI Steps

Defend Workflows Cypress Tests on Serverless #1

Test Failures

[job] [logs] Defend Workflows Cypress Tests on Serverless #1 / Endpoint generated alerts "before each" hook for "should create a Detection Engine alert from an endpoint alert" "before each" hook for "should create a Detection Engine alert from an endpoint alert"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolution`	4651	4656	+5

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`expressions`	1749	1765	+16

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`expressionXY`	131.2KB	132.1KB	+903.0B
`lens`	1.4MB	1.4MB	+98.0B
`securitySolution`	12.8MB	12.9MB	+18.3KB
total			+19.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`expressions`	98.1KB	98.3KB	+175.0B
`expressionXY`	38.7KB	38.7KB	+48.0B
total			+223.0B

Unknown metric groups

API count

id	before	after	diff
`expressions`	2208	2224	+16

History

💔 Build #172290 failed 2b675ee
💔 Build #172218 failed 23bcbdd
💔 Build #172206 failed 2fcd808
💔 Build #172197 failed 2408dc2
💔 Build #172179 failed ff0c7c8
💔 Build #172172 failed aef63c5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…ine (elastic#170127) ## Summary elastic#168199 elastic#169656 https://github.com/elastic/kibana/assets/6295984/ff5cee55-6da5-4636-85f5-a697a302f8b5 --------- Co-authored-by: Michael Olorunnisola <[email protected]> Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 8103a44)

kibanamachine · 2023-10-31T17:37:33Z

💚 All backports created successfully

Status	Branch	Result
✅	8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…n timeline (#170127) (#170269) # Backport This will backport the following commits from `main` to `8.11`: - [[SecuritySolution] Fix topN legend actions - filter in / out in timeline (#170127)](#170127)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Angela Chuang <[email protected]> Co-authored-by: Michael Olorunnisola <[email protected]>

…ine (elastic#170127) ## Summary elastic#168199 elastic#169656 https://github.com/elastic/kibana/assets/6295984/ff5cee55-6da5-4636-85f5-a697a302f8b5 --------- Co-authored-by: Michael Olorunnisola <[email protected]> Co-authored-by: kibanamachine <[email protected]>

…lter actions in visualizations (elastic#171284) ## Summary Bug: elastic#171167 The [previous implementation](elastic#170127) solved a different bug using a new `shouldShowLegendAction` property. This approach had a limitation on the Security Dashboards page since the Security app has no control over the properties passed to the visualization components when they are rendered through portable Dashboards. This PR fixes the problem by checking if any of the registered actions is a "filter" action `type` in the visualizations. If customized filter actions are found, the default filter actions hardcoded in the visualizations code are not added, preventing duplication of filter actions. The specific action `type` used for the check is the `FILTER_CELL_ACTION_TYPE = 'cellAction-filter'` constant exported by the `@kbn/cell-actions` package. This new approach uses a property stored in the registered actions themselves, so we don't need to pass any extra property to the visualization components, it works transparently. So the `shouldShowLegendAction` property has also been cleaned. ## Demos Timeline using `showTopN` visualization: https://github.com/elastic/kibana/assets/17747913/491c08e8-0740-4c9e-9cb7-81267b9ba040 Alerts page using `Counts` table visualization and `showTopN` visualization https://github.com/elastic/kibana/assets/17747913/683eec6c-382e-4ae9-9400-c1022922e488 Portable Dashboard visualizations: https://github.com/elastic/kibana/assets/17747913/50f09a65-488d-41f2-a5b8-3882d9c80678 Security actions are "compatible" only inside the Security app, in the Lens app the default filter actions are displayed: <img width="1682" alt="lens-actions-screenshot" src="https://github.com/elastic/kibana/assets/17747913/1e7ce929-129d-45a9-ba71-8d28e3726454"> --------- Co-authored-by: kibanamachine <[email protected]>

michaelolo24 and others added 4 commits October 23, 2023 20:30

add custom filter for

4945765

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

0e65f6d

…-fix'

hide default legend actions by sourcerer scope

4773232

custom legend actions

478163a

angorayc commented Oct 30, 2023

View reviewed changes

fix test

06e09d3

michaelolo24 approved these changes Oct 30, 2023

View reviewed changes

kibanamachine and others added 11 commits October 30, 2023 20:14

Merge branch 'main' into fix-topn-filters

b65d1a6

rename params

1785ef5

types

958cc07

Merge branch 'fix-topn-filters' of github.com:angorayc/kibana into fi…

aef63c5

…x-topn-filters

rename

33958b2

types

ff0c7c8

types

2408dc2

types

2fcd808

types

23bcbdd

Merge branch 'main' of github.com:elastic/kibana into fix-topn-filters

8dac7c1

unit tests

337c55d

angorayc changed the title ~~Fix topn filters~~ [SecuritySolution] Fix topN legend actions - filter in / out in timeline Oct 31, 2023

fix cypress

2b675ee

angorayc marked this pull request as ready for review October 31, 2023 15:51

angorayc requested review from a team as code owners October 31, 2023 15:51

michaelolo24 self-requested a review October 31, 2023 15:51

michaelolo24 approved these changes Oct 31, 2023

View reviewed changes

botelastic bot added the Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) label Oct 31, 2023

angorayc added release_note:fix Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Oct 31, 2023

angorayc added Team:Threat Hunting:Explore v8.11.0 v8.12.0 labels Oct 31, 2023

angorayc added v8.11.1 Feature:Lens Charts Security Solution Lens Charts feature labels Oct 31, 2023

drewdaemon approved these changes Oct 31, 2023

View reviewed changes

lint

8b6efbe

angorayc enabled auto-merge (squash) October 31, 2023 16:06

angorayc merged commit 8103a44 into elastic:main Oct 31, 2023

kibanamachine mentioned this pull request Oct 31, 2023

[8.11] [SecuritySolution] Fix topN legend actions - filter in / out in timeline (#170127) #170269

Merged

This was referenced Nov 15, 2023

[Security Solution] [Bug] Multiple filtering actions in Lens visualizations #171167

Closed

[Security Solution][Lens] Check filter action type to hide default filter actions in visualizations #171284

Merged

drewdaemon mentioned this pull request Nov 16, 2023

[Lens] allow embeddable client to customize legend filter actions #169656

Closed

semd mentioned this pull request Mar 11, 2024

[Security Solution] Show top N moves to the top-left corner when it loses the anchor #169694

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SecuritySolution] Fix topN legend actions - filter in / out in timeline #170127

[SecuritySolution] Fix topN legend actions - filter in / out in timeline #170127

angorayc commented Oct 30, 2023 •

edited by kibanamachine

Loading

angorayc Oct 30, 2023

michaelolo24 left a comment

michaelolo24 commented Oct 31, 2023

elasticmachine commented Oct 31, 2023

elasticmachine commented Oct 31, 2023

drewdaemon left a comment

kibana-ci commented Oct 31, 2023

API count

kibanamachine commented Oct 31, 2023

[SecuritySolution] Fix topN legend actions - filter in / out in timeline #170127

[SecuritySolution] Fix topN legend actions - filter in / out in timeline #170127

Conversation

angorayc commented Oct 30, 2023 • edited by kibanamachine Loading

Summary

angorayc Oct 30, 2023

Choose a reason for hiding this comment

michaelolo24 left a comment

Choose a reason for hiding this comment

michaelolo24 commented Oct 31, 2023

elasticmachine commented Oct 31, 2023

elasticmachine commented Oct 31, 2023

drewdaemon left a comment

Choose a reason for hiding this comment

kibana-ci commented Oct 31, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

History

kibanamachine commented Oct 31, 2023

💚 All backports created successfully

Questions ?

angorayc commented Oct 30, 2023 •

edited by kibanamachine

Loading