[Watcher] Fix sorting on JSX headers #170085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ikuni17
added
release_note:fix
backport:prev-minor
ElenaStoeva
approved these changes
Oct 30, 2023
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @Ikuni17 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 30, 2023
## Summary Closes elastic#164126 EUI in memory tables need to have stable headers between renders to sort properly when the header is a JSX element ([Docs](https://eui.elastic.co/#/tabular-content/in-memory-tables)). This PR stabilizes the headers for `WatchListPage` only. I noticed there were some other columns which likely have the same issue in Watcher, but I'm unsure how far reaching these changes need to be. Reading through the issue @ElenaStoeva mentions changing the sorting anyways, so a quick fix seems more appropriate.  ## Release Note Fixed issue where certain columns in the Watcher table were not sorting properly. (cherry picked from commit 540e6c0)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Ikuni17
added a commit
that referenced
this pull request
Nov 9, 2023
# Backport This will backport the following commits from `main` to `8.11`: - [[Watcher] Fix sorting on JSX headers (#170085)](#170085) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Brad White","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-30T15:34:43Z","message":"[Watcher] Fix sorting on JSX headers (#170085)\n\n## Summary\r\nCloses #164126\r\n\r\nEUI in memory tables need to have stable headers between renders to sort\r\nproperly when the header is a JSX element\r\n([Docs](https://eui.elastic.co/#/tabular-content/in-memory-tables)).\r\nThis PR stabilizes the headers for `WatchListPage` only. I noticed there\r\nwere some other columns which likely have the same issue in Watcher, but\r\nI'm unsure how far reaching these changes need to be. Reading through\r\nthe issue @ElenaStoeva mentions changing the sorting anyways, so a quick\r\nfix seems more appropriate.\r\n\r\n\r\n\r\n\r\n\r\n## Release Note\r\nFixed issue where certain columns in the Watcher table were not sorting\r\nproperly.","sha":"540e6c0acb1b357e4f309091b27a6bdc24bf04c0","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:prev-minor","v8.12.0"],"number":170085,"url":"https://github.com/elastic/kibana/pull/170085","mergeCommit":{"message":"[Watcher] Fix sorting on JSX headers (#170085)\n\n## Summary\r\nCloses #164126\r\n\r\nEUI in memory tables need to have stable headers between renders to sort\r\nproperly when the header is a JSX element\r\n([Docs](https://eui.elastic.co/#/tabular-content/in-memory-tables)).\r\nThis PR stabilizes the headers for `WatchListPage` only. I noticed there\r\nwere some other columns which likely have the same issue in Watcher, but\r\nI'm unsure how far reaching these changes need to be. Reading through\r\nthe issue @ElenaStoeva mentions changing the sorting anyways, so a quick\r\nfix seems more appropriate.\r\n\r\n\r\n\r\n\r\n\r\n## Release Note\r\nFixed issue where certain columns in the Watcher table were not sorting\r\nproperly.","sha":"540e6c0acb1b357e4f309091b27a6bdc24bf04c0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/170085","number":170085,"mergeCommit":{"message":"[Watcher] Fix sorting on JSX headers (#170085)\n\n## Summary\r\nCloses #164126\r\n\r\nEUI in memory tables need to have stable headers between renders to sort\r\nproperly when the header is a JSX element\r\n([Docs](https://eui.elastic.co/#/tabular-content/in-memory-tables)).\r\nThis PR stabilizes the headers for `WatchListPage` only. I noticed there\r\nwere some other columns which likely have the same issue in Watcher, but\r\nI'm unsure how far reaching these changes need to be. Reading through\r\nthe issue @ElenaStoeva mentions changing the sorting anyways, so a quick\r\nfix seems more appropriate.\r\n\r\n\r\n\r\n\r\n\r\n## Release Note\r\nFixed issue where certain columns in the Watcher table were not sorting\r\nproperly.","sha":"540e6c0acb1b357e4f309091b27a6bdc24bf04c0"}}]}] BACKPORT--> Co-authored-by: Brad White <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #164126
EUI in memory tables need to have stable headers between renders to sort properly when the header is a JSX element (Docs). This PR stabilizes the headers for
WatchListPageonly. I noticed there were some other columns which likely have the same issue in Watcher, but I'm unsure how far reaching these changes need to be. Reading through the issue @ElenaStoeva mentions changing the sorting anyways, so a quick fix seems more appropriate.Release Note
Fixed issue where certain columns in the Watcher table were not sorting properly.