Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics] Update alert condition text #170013

Merged
merged 2 commits into from
Oct 30, 2023
Merged

[Synthetics] Update alert condition text #170013

merged 2 commits into from
Oct 30, 2023

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Oct 27, 2023 •
edited by kibanamachine
Loading

Summary

Fixes #168727

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v8.11.0 v8.12.0 labels Oct 27, 2023
@shahzad31 shahzad31 marked this pull request as ready for review October 27, 2023 11:24
@shahzad31 shahzad31 requested a review from a team as a code owner October 27, 2023 11:24
justinkambic
justinkambic approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I didn't smoke test as it's only a copy change.

@awahab07 awahab07 merged commit d1c587f into elastic:main Oct 30, 2023
6 checks passed
@kibanamachine kibanamachine mentioned this pull request Oct 30, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 30, 2023
@shahzad31
[Synthetics] Update alert condition text (elastic#170013)
1e2bc2e 
## Summary

Fixes elastic#168727

(cherry picked from commit d1c587f)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 30, 2023
@kibanamachine @shahzad31
[8.11] [Synthetics] Update alert condition text (#170013) (#170134)
228a59b 
# Backport

This will backport the following commits from `main` to `8.11`:
- [[Synthetics] Update alert condition text
(#170013)](#170013)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-30T14:59:44Z","message":"[Synthetics]
Update alert condition text (#170013)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/168727","sha":"d1c587ff1d072735e109cff5c16ca6a243eacea3","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.11.0","v8.12.0"],"number":170013,"url":"https://github.com/elastic/kibana/pull/170013","mergeCommit":{"message":"[Synthetics]
Update alert condition text (#170013)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/168727","sha":"d1c587ff1d072735e109cff5c16ca6a243eacea3"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/170013","number":170013,"mergeCommit":{"message":"[Synthetics]
Update alert condition text (#170013)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/168727","sha":"d1c587ff1d072735e109cff5c16ca6a243eacea3"}}]}]
BACKPORT-->

Co-authored-by: Shahzad <[email protected]>
@shahzad31 shahzad31 deleted the fix-alert-typo branch June 6, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinkambic justinkambic justinkambic approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v8.11.0 v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong comparison in uptime alert message
6 participants
@shahzad31 @apmmachine @kibana-ci @kibanamachine @justinkambic @awahab07