Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken yarn.lock #17001

Merged
merged 1 commit into from
Mar 7, 2018
Merged

Fix broken yarn.lock #17001

merged 1 commit into from
Mar 7, 2018

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Mar 7, 2018 •
edited
Loading

Fix a missing dependency in yarn.lock, that was introduced due to an old PR (#12753) by me, that has been created before the switch to yarn.

@timroes timroes added the bug Fixes for quality problems that affect the customer experience label Mar 7, 2018
stacey-gammon
stacey-gammon approved these changes Mar 7, 2018
View reviewed changes
Copy link
Contributor

@stacey-gammon stacey-gammon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending passing ci. Just pointing out that it looks like you switched from 1.0.0 in the old PR to 2.1.1 but as long as it all still works on 2.1.1, and you are aware, lgtm!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@stacey-gammon
Copy link
Contributor

Since I believe this is breaking the build on master... I'm going to go ahead and merge into master now that the PR is passing.

@stacey-gammon stacey-gammon merged commit 0677f42 into elastic:master Mar 7, 2018
@timroes timroes mentioned this pull request Mar 7, 2018
Merged
timroes added a commit to timroes/kibana that referenced this pull request Mar 7, 2018
@timroes
Fix broken yarn.lock (elastic#17001)
a97110e
timroes added a commit that referenced this pull request Mar 7, 2018
@timroes
[6.x] Make plugin installer proxy work for HTTPS (#15588) | Fix broke…
821adab 
…n yarn.lock (#17001) (#17011)

* Make plugin installer proxy work for HTTPS (#15588)

* Fix broken yarn.lock (#17001)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stacey-gammon stacey-gammon stacey-gammon approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timroes @elasticmachine @stacey-gammon