[ML] AIOps: Fixes Change point embeddable reporting #169962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnautov
added
release_note:fix
(Deprecated) Feature:Reporting
darnautov
added
Feature:ML/AIOps
|
Pinging @elastic/ml-ui (:ml) |
darnautov
commented
Oct 26, 2023
| @@ -205,7 +205,7 @@ export const FormControls: FC<{ | |||
| return; | |||
| } | |||
|
|
|||
| if (metricFieldOptions === prevMetricFieldOptions) return; | |||
| if (!prevMetricFieldOptions || metricFieldOptions === prevMetricFieldOptions) return; | |||
There was a problem hiding this comment.
This line fixes the embeddable input editing from the Dashboard
…-ref HEAD~1..HEAD --fix'
darnautov
commented
Oct 26, 2023
x-pack/plugins/aiops/public/embeddable/embeddable_chart_component_wrapper.tsx
Show resolved
Hide resolved
walterra
reviewed
Oct 27, 2023
x-pack/plugins/aiops/public/components/change_point_detection/charts_grid.tsx
Outdated
Show resolved
Hide resolved
8 tasks
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
peteharverson
approved these changes
Oct 27, 2023
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @darnautov |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Oct 27, 2023
## Summary Fixes elastic#169733 #### Reporting fix Change point detection embeddable was incorrectly reporting render completion. It was relying on the `onLoad` callback from the Lens embeddable responsible for chart rendering, which only indicates that data fetching is complete, but not the actual rendering. Current implementation relies on the `renderComplete` event from each child embeddable. Both PNG and PDF exports tested and work as expected.  #### Additional fixes - Fixes the metric and split field controls states when editing existing Change point embeddable from a dashboard - Fixes `filter` query if partitions input is initialized as an empty array. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 80d382a) # Conflicts: # .eslintrc.js
darnautov
added a commit
that referenced
this pull request
Oct 30, 2023
…170046) # Backport This will backport the following commits from `main` to `8.11`: - [[ML] AIOps: Fix Change point embeddable reporting (#169962)](#169962) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dima Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-27T15:13:52Z","message":"[ML] AIOps: Fix Change point embeddable reporting (#169962)\n\n## Summary\r\n\r\nFixes #169733\r\n\r\n#### Reporting fix\r\n\r\nChange point detection embeddable was incorrectly reporting render\r\ncompletion. It was relying on the `onLoad` callback from the Lens\r\nembeddable responsible for chart rendering, which only indicates that\r\ndata fetching is complete, but not the actual rendering. Current\r\nimplementation relies on the `renderComplete` event from each child\r\nembeddable. Both PNG and PDF exports tested and work as expected.\r\n\r\n\r\n\r\n\r\n#### Additional fixes\r\n\r\n- Fixes the metric and split field controls states when editing existing\r\nChange point embeddable from a dashboard\r\n- Fixes `filter` query if partitions input is initialized as an empty\r\narray.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"80d382a22f2adc39a63146d3ffb5cb7763090c2e","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:Reporting",":ml","Team:ML","Feature:ML/AIOps","Feature:Embeddables","v8.11.0","v8.12.0"],"number":169962,"url":"https://github.com/elastic/kibana/pull/169962","mergeCommit":{"message":"[ML] AIOps: Fix Change point embeddable reporting (#169962)\n\n## Summary\r\n\r\nFixes #169733\r\n\r\n#### Reporting fix\r\n\r\nChange point detection embeddable was incorrectly reporting render\r\ncompletion. It was relying on the `onLoad` callback from the Lens\r\nembeddable responsible for chart rendering, which only indicates that\r\ndata fetching is complete, but not the actual rendering. Current\r\nimplementation relies on the `renderComplete` event from each child\r\nembeddable. Both PNG and PDF exports tested and work as expected.\r\n\r\n\r\n\r\n\r\n#### Additional fixes\r\n\r\n- Fixes the metric and split field controls states when editing existing\r\nChange point embeddable from a dashboard\r\n- Fixes `filter` query if partitions input is initialized as an empty\r\narray.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"80d382a22f2adc39a63146d3ffb5cb7763090c2e"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169962","number":169962,"mergeCommit":{"message":"[ML] AIOps: Fix Change point embeddable reporting (#169962)\n\n## Summary\r\n\r\nFixes #169733\r\n\r\n#### Reporting fix\r\n\r\nChange point detection embeddable was incorrectly reporting render\r\ncompletion. It was relying on the `onLoad` callback from the Lens\r\nembeddable responsible for chart rendering, which only indicates that\r\ndata fetching is complete, but not the actual rendering. Current\r\nimplementation relies on the `renderComplete` event from each child\r\nembeddable. Both PNG and PDF exports tested and work as expected.\r\n\r\n\r\n\r\n\r\n#### Additional fixes\r\n\r\n- Fixes the metric and split field controls states when editing existing\r\nChange point embeddable from a dashboard\r\n- Fixes `filter` query if partitions input is initialized as an empty\r\narray.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"80d382a22f2adc39a63146d3ffb5cb7763090c2e"}}]}] BACKPORT-->
szabosteve
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #169733
Reporting fix
Change point detection embeddable was incorrectly reporting render completion. It was relying on the
onLoadcallback from the Lens embeddable responsible for chart rendering, which only indicates that data fetching is complete, but not the actual rendering. Current implementation relies on therenderCompleteevent from each child embeddable. Both PNG and PDF exports tested and work as expected.Additional fixes
filterquery if partitions input is initialized as an empty array.Checklist