[HTTP] Add more info to the log.error metadata #169552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
added
Feature:http
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
gsoldevila
reviewed
Oct 24, 2023
| @@ -217,7 +217,11 @@ export class Router<Context extends RequestHandlerContextBase = RequestHandlerCo | |||
| // forward 401 errors from ES client | |||
| if (isElasticsearchUnauthorizedError(error)) { | |||
| this.log.error(`401 Unauthorized`, { | |||
| http: { response: { status_code: 401 } }, | |||
| http: { | |||
There was a problem hiding this comment.
We can enrich the error logged on line 203 too.
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @afharo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding a few fields to the ECS metadata in the HTTP error logs:
error.message: cherry-picking the error message only to avoid unintended leak of information if the error contains too much info in its propertiesrequest.methodandrequest.path: so that we know to which handler the error is scoped. Note that the path is the registered path (with variable templates), not the final pathThe reason: we need to be able to have a hint of what's the error behind a blind
[ERROR][http] 500 Server Error.For maintainers