[Infra UI] Removed unused saved object attribute and unused source configuration code

[neptunian]

Resolves #168240

Changes

• Removes fields.message from the infrastructure-ui-source saved object who's value was being populated by xpack.infra.sources.default.fields.message from config. See https://www.elastic.co/guide/en/kibana/master/logs-ui-settings-kb.html
• Removes getInternalSourceConfiguration and defineInternalSourceConfiguration functions introduced in [Logs UI] Allow for plugins to inject internal source configurations #36066 as I cannot see them being used anywhere. Stops exposing defineInternalSourceConfiguration as part of server plugin interface.
• Removes getStaticDefaultSourceConfiguration from InfraSources class as we aren't using sources from kibana config in source configuration anymore.
• Removes deprecations warning of removal in 8.0 for other fields belonging to config xpack.infra.sources.* introduced in [Logs/Metrics UI] Add deprecated field configuration to Deprecations API #115103
• Removes getAllSourceConfigurations used only in removed deprecations file f427278#diff-081721894fc437938eb652beae0a0640ddeee532ec5e48af1f3093c8074f1eecL195
• Removed getAllSavedSourceConfigurations only used in getAllSourceConfigurations

How to test

• infrastructure-ui-source saved object no longer has fields attributes
  • in kibana.yml set xpack.infra.sources.default.fields.message: ['testmessage', '@testmessage']
  • go to Infra -> Settings
  • Change the name and save the form
  • view the infrastructure-ui-source saved object and no fields attribute should exist (unless it previously existed in an already existing infrastructure-ui-source saved object
• changes do not affectfields.message is used in logs_shared plugin
  • i'm not sure how to easily test this and relying on someone with more Logs knowledge to help out, but from what I can see logs accesses the config directly (xpack.infra.sources.default.fields.message) and never uses the saved object field being removed.

[apmmachine]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
• /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[neptunian]

this function looked for sources field in the kibana infra config and returned it as part of source configuration. It merges it with "default configuration". we can remove this function and just get the default configuration since we aren't using sources from config in our source configuration anymore.

[neptunian]

this is testing for kibana config values in sources field, which is no longer supported as part of source configuration. I assume at some point in the past metricAlias and logsIndices was able to be set in the kibana config from looking at this test. Under xpack.infra.sources.default.metricAlias, etc.

[elasticmachine]

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: db33848

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
infra	39	36	-3

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
infra	11	10	-1

Unknown metric groups

API count

id	before	after	diff
infra	42	39	-3

History

• 💛 Build #172307 was flaky 1f6040e2547c7352a2b33aea722c1c545a0526cd
• 💔 Build #172158 failed 608cf1c95d35fe29fa3f83dcfd83ba30e166731d
• 💔 Build #172137 failed a7997ec35491f8ec41e0251927f99dd90d9399aa
• 💔 Build #169679 failed 28c91871fca36eb1f70ac3540010c91fe3bbe5e2
• 💔 Build #169593 failed 250e60f42f08c2d63e3a74637a64ad761074625b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[crespocarlos]

Looks good.

I tested it against a clean local ES cluster, and the fields.message attribute is gone.

However, I still see it on my oblt-cli cluster, even after saving the infra settings form.

Is this also supposed to remove it from existent saved objects too?

[neptunian]

@crespocarlos Thanks. You're correct and I updated the testing instructions to expect it to still exist if it already existed on the saved object. I am thinking to not bother removing it and new objects created will no longer have it.