Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security] Enable credential fields in integration edit #169365

Merged
merged 5 commits into from
Oct 19, 2023

Conversation

JordanSh
Copy link
Contributor

@JordanSh JordanSh commented Oct 19, 2023

Summary

Resolves #169353

  • Enabled the credential fields in edit mode.
  • Switching between credential and account type is still disabled.
  • For GCP, the Org and Project ID are still disabled.
Screen.Recording.2023-10-19.at.13.56.14.mov

@JordanSh JordanSh added release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.11.0 labels Oct 19, 2023
@JordanSh JordanSh self-assigned this Oct 19, 2023
@JordanSh JordanSh marked this pull request as ready for review October 19, 2023 14:10
@JordanSh JordanSh requested a review from a team as a code owner October 19, 2023 14:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

Copy link
Contributor

@Omolola-Akinleye Omolola-Akinleye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JordanSh JordanSh enabled auto-merge (squash) October 19, 2023 18:57
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Serverless Osquery Cypress Tests #1 / ALL - Packs Global packs add proper shard to policies packs config

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 400.2KB 400.1KB -123.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @JordanSh

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 19, 2023
…169365) (#169451)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[Cloud Security] Enable credential fields in integration edit
(#169365)](#169365)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Jordan","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-19T20:30:48Z","message":"[Cloud
Security] Enable credential fields in integration edit
(#169365)","sha":"44f3910763996da35cb9a22ce8042da309319d91","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Cloud
Security","v8.11.0","v8.12.0"],"number":169365,"url":"https://github.com/elastic/kibana/pull/169365","mergeCommit":{"message":"[Cloud
Security] Enable credential fields in integration edit
(#169365)","sha":"44f3910763996da35cb9a22ce8042da309319d91"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169365","number":169365,"mergeCommit":{"message":"[Cloud
Security] Enable credential fields in integration edit
(#169365)","sha":"44f3910763996da35cb9a22ce8042da309319d91"}}]}]
BACKPORT-->

Co-authored-by: Jordan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.11.0 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cloud Security] Enable credential fields on edit mode
5 participants