Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shared UX] Remove color="ghost" on EuiBottomBar children #169307

Merged
merged 6 commits into from
Oct 25, 2023
Merged

[Shared UX] Remove color="ghost" on EuiBottomBar children #169307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
93172f9
[kbn-management] Remove unnecessary `ghost` colors from bottom bar
cee-chen Oct 18, 2023
a7819b7
[painless_lab] Remove unnecessary `ghost` colors from bottom bar
cee-chen Oct 18, 2023
23d8c04
[advanced_settings] Remove unnecessary `ghost` colors from bottom bar
cee-chen Oct 18, 2023
3d48044
Merge branch 'main' into eui-ghost/platform-deployment-management
cee-chen Oct 18, 2023
58548ef
Merge branch 'main' into eui-ghost/platform-deployment-management
cee-chen Oct 19, 2023
fdb7ed1
Merge branch 'main' into eui-ghost/platform-deployment-management
cee-chen Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/kbn-management/settings/components/form/bottom_bar/bottom_bar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export const BottomBar = ({
<EuiFlexItem grow={false}>
<EuiButtonEmpty
css={cssFormButton}
color="ghost"
color="text"
size="s"
iconType="cross"
onClick={onClearAllUnsaved}
Expand Down
2 changes: 1 addition & 1 deletion packages/kbn-management/settings/components/form/bottom_bar/unsaved_count.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ interface UnsavedCountProps {
export const UnsavedCount = ({ unsavedCount }: UnsavedCountProps) => {
const { cssFormUnsavedCountMessage } = useFormStyles();
return (
<EuiText size="s" color="ghost" css={cssFormUnsavedCountMessage}>
<EuiText size="s" css={cssFormUnsavedCountMessage}>
<FormattedMessage
id="management.settings.form.countOfSettingsChanged"
defaultMessage="{unsavedCount} unsaved {unsavedCount, plural,
Expand Down
8 changes: 4 additions & 4 deletions src/plugins/advanced_settings/public/management_app/components/form/form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {
EuiLink,
EuiCallOut,
EuiSpacer,
EuiTextColor,
EuiText,
EuiBottomBar,
EuiButton,
EuiToolTip,
Expand Down Expand Up @@ -314,7 +314,7 @@ export class Form extends PureComponent<FormProps> {
const unsavedCount = this.getCountOfUnsavedChanges();
const hiddenUnsavedCount = this.getCountOfHiddenUnsavedChanges();
return (
<EuiTextColor className="mgtAdvancedSettingsForm__unsavedCountMessage" color="ghost">
<EuiText className="mgtAdvancedSettingsForm__unsavedCountMessage">
<FormattedMessage
id="advancedSettings.form.countOfSettingsChanged"
defaultMessage="{unsavedCount} unsaved {unsavedCount, plural,
Expand All @@ -329,7 +329,7 @@ export class Form extends PureComponent<FormProps> {
hiddenCount: hiddenUnsavedCount,
}}
/>
</EuiTextColor>
</EuiText>
);
};

Expand All @@ -349,7 +349,7 @@ export class Form extends PureComponent<FormProps> {
<EuiFlexItem />
<EuiFlexItem grow={false}>
<EuiButtonEmpty
color="ghost"
color="text"
size="s"
iconType="cross"
onClick={this.clearAllUnsaved}
Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/painless_lab/public/application/components/main_controls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ export function MainControls({ toggleRequestFlyout, isRequestFlyoutOpen, reset,
size="s"
iconType="help"
iconSide="left"
color="ghost"
color="text"
onClick={() => setIsHelpOpen(!isHelpOpen)}
>
{i18n.translate('xpack.painlessLab.helpButtonLabel', {
Expand All @@ -114,7 +114,7 @@ export function MainControls({ toggleRequestFlyout, isRequestFlyoutOpen, reset,
<EuiFlexItem grow={false}>
<EuiButtonEmpty
size="s"
color="ghost"
color="text"
onClick={toggleRequestFlyout}
data-test-subj="btnViewRequest"
>
Expand Down
Loading