[Security Solution][API testing] Move and restructures action groups in the new api integration test folder #169234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WafaaNasr
added
release_note:skip
vitaliidm
reviewed
Oct 19, 2023
...ty_solution_api_integration/test_suites/detections_response/default_license/actions/index.ts
Outdated
Show resolved
Hide resolved
…Nasr/kibana into move-structure-actions-api
…ructure-actions-api
…ructure-actions-api
…ructure-actions-api
…ructure-actions-api
…ructure-actions-api
…Nasr/kibana into move-structure-actions-api
…ructure-actions-api
…Nasr/kibana into move-structure-actions-api
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @WafaaNasr |
yctercero
reviewed
Oct 30, 2023
| const es = getService('es'); | ||
| const esArchiver = getService('esArchiver'); | ||
|
|
||
| describe('@ess @skipInQA actions migrations', () => { |
There was a problem hiding this comment.
If we add @ess - should that be enough to exclude all serverless related tags since @skipInQA is particular to serverless?
There was a problem hiding this comment.
Note: being addressed in follow up PR to unblock others.
yctercero
reviewed
Oct 30, 2023
x-pack/test/detection_engine_api_integration/security_and_spaces/group1/index.ts
Show resolved
Hide resolved
yctercero
reviewed
Oct 30, 2023
| import { getSimpleRuleOutput } from './get_simple_rule_output'; | ||
| import { RuleWithoutServerGeneratedProperties } from './remove_server_generated_properties'; | ||
|
|
||
| export const getSimpleRuleOutputWithWebHookAction = ( |
There was a problem hiding this comment.
Since these were only used in the add_action.ts and update_action.ts which seemed to have been part of the migration, can we remove this util from the old folder?
There was a problem hiding this comment.
Note: being addressed in follow up PR to unblock others.
kibanamachine
added
v8.12.0
backport:skip
WafaaNasr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://docs.google.com/document/d/1CRFfDWMzw3ob03euWIvT4-IoiLXjoiPWI8mTBqP4Zks/edit
@skipInQAtag to the failing tests in QA env