Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Unskip rules export import serverless cypress tests #169230

Merged
merged 1 commit into from
Oct 18, 2023
Merged

[Security Solution] Unskip rules export import serverless cypress tests #169230

merged 1 commit into from
Oct 18, 2023

Conversation

maximpn
Copy link
Contributor

@maximpn maximpn commented Oct 18, 2023 •
edited
Loading

Addresses: #161540

Summary

This PR unskips import and export security rules Serverless Cypress tests.

Flaky test runner

import_export folder 150 runs

@maximpn maximpn added test release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team 8.12 candidate labels Oct 18, 2023
@maximpn maximpn self-assigned this Oct 18, 2023
@maximpn maximpn force-pushed the unskip-rules-export-import-serverless-cypress-tests branch from 2f8f6d9 to fb1f119 Compare October 18, 2023 15:20
@maximpn maximpn requested a review from jpdjere October 18, 2023 15:20
@maximpn maximpn marked this pull request as ready for review October 18, 2023 15:20
@maximpn maximpn requested a review from a team as a code owner October 18, 2023 15:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

jpdjere
jpdjere approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@jpdjere jpdjere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes and flaky test runner looking good 👍

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💚 Build #168997 succeeded 2f8f6d9bda735c766c04a1bbb9edf043424120a1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maximpn

@maximpn maximpn merged commit d08ad0c into elastic:main Oct 18, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 18, 2023
@maximpn maximpn deleted the unskip-rules-export-import-serverless-cypress-tests branch October 18, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpdjere jpdjere jpdjere approved these changes

Assignees

@maximpn maximpn

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. test v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maximpn @elasticmachine @kibana-ci @jpdjere @kibanamachine