Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Unskip Security Solution Accessibility tests #169223

Merged
merged 5 commits into from
Oct 24, 2023
Merged

[Security Solution] Unskip Security Solution Accessibility tests #169223

merged 5 commits into from
Oct 24, 2023

Conversation

jpdjere
Copy link
Contributor

@jpdjere jpdjere commented Oct 18, 2023 •
edited
Loading

Summary

Flaky test runner for Cypress tests:

  • x-pack/test/accessibility/apps/security_solution.ts

Changes

-x-pack/test/accessibility/apps/security_solution.ts unskip tests

Related failing-test issues

  1. Failing test: X-Pack Accessibility Tests.x-pack/test/accessibility/apps/security_solution·ts - Security Solution Accessibility Detections Create Rule Flow Custom Query Rule Define Step About Step "before each" hook for "advanced settings view meets a11y requirements" #166102
  2. Failing test: X-Pack Accessibility Tests.x-pack/test/accessibility/apps/security_solution·ts - Security Solution Accessibility Detections Create Rule Flow Custom Query Rule Define Step About Step "before each" hook for "default view meets a11y requirements" #166105

Flaky test runner link

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3586 🟢

Changes

  • Unskipping skipped Accessibility integration tests.

@jpdjere jpdjere marked this pull request as draft October 19, 2023 09:07
This was referenced Oct 19, 2023
Closed
Closed
Closed
@jpdjere jpdjere changed the title [Security Solution] Flaky test runner for Security Solution Accessibility tests [Security Solution] Unskip Security Solution Accessibility tests Oct 23, 2023
@jpdjere jpdjere marked this pull request as ready for review October 23, 2023 14:23
@jpdjere jpdjere requested a review from a team October 23, 2023 14:23
@jpdjere jpdjere self-assigned this Oct 23, 2023
@jpdjere jpdjere added release_note:skip Skip the PR/issue when compiling release notes v8.12.0 Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Engine Security Solution Detection Engine Area labels Oct 23, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@jpdjere
Copy link
Contributor Author

jpdjere commented Oct 23, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Serverless Osquery Cypress Tests #1 / ALL - Packs Load prebuilt packs should be able to add policy to it should be able to add policy to it
  • [job] [logs] Serverless Osquery Cypress Tests #1 / ALL - Packs Load prebuilt packs should be able to run live prebuilt pack should be able to run live prebuilt pack

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jpdjere

@jpdjere jpdjere merged commit 6beee47 into elastic:main Oct 24, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 24, 2023
@jpdjere jpdjere deleted the security-solution-accessibility-flaky branch October 24, 2023 09:21
jpdjere added a commit to jpdjere/kibana that referenced this pull request Oct 24, 2023
@jpdjere
[Security Solution] Unskip Security Solution Accessibility tests (e…
d7d7b0d 
…lastic#169223)

## Summary

Flaky test runner for Cypress tests:
- `x-pack/test/accessibility/apps/security_solution.ts`

## Changes

-`x-pack/test/accessibility/apps/security_solution.ts` **unskip tests**

## Related failing-test issues

1. elastic#166102
2. elastic#166105

## Flaky test runner link

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3586
🟢

## Changes

- Unskipping skipped Accessibility integration tests.

---------

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 6beee47)
@jpdjere jpdjere mentioned this pull request Oct 24, 2023
Merged
@jpdjere
Copy link
Contributor Author

jpdjere commented Oct 24, 2023

💚 All backports created successfully

Status Branch Result
✅ 8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

jpdjere added a commit that referenced this pull request Oct 24, 2023
@jpdjere
[8.11] [Security Solution] Unskip Security Solution Accessibility t…
15de3b1 
…ests (#169223) (#169683)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[Security Solution] Unskip `Security Solution Accessibility` tests
(#169223)](#169223)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Juan Pablo
Djeredjian","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-24T08:26:56Z","message":"[Security
Solution] Unskip `Security Solution Accessibility` tests (#169223)\n\n##
Summary\r\n\r\nFlaky test runner for Cypress tests:\r\n-
`x-pack/test/accessibility/apps/security_solution.ts`\r\n\r\n##
Changes\r\n\r\n-`x-pack/test/accessibility/apps/security_solution.ts`
**unskip tests**\r\n\r\n## Related failing-test issues\r\n\r\n1.
https://github.com/elastic/kibana/issues/166102\r\n2.
https://github.com/elastic/kibana/issues/166105\r\n\r\n## Flaky test
runner
link\r\n\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3586\r\n🟢\r\n\r\n##
Changes\r\n\r\n- Unskipping skipped Accessibility integration
tests.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"6beee472486c547adf5a7a0033f7c01c197c6d02","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","Team:Detections
and Resp","Team: SecuritySolution","Team:Detection
Engine","v8.12.0"],"number":169223,"url":"https://github.com/elastic/kibana/pull/169223","mergeCommit":{"message":"[Security
Solution] Unskip `Security Solution Accessibility` tests (#169223)\n\n##
Summary\r\n\r\nFlaky test runner for Cypress tests:\r\n-
`x-pack/test/accessibility/apps/security_solution.ts`\r\n\r\n##
Changes\r\n\r\n-`x-pack/test/accessibility/apps/security_solution.ts`
**unskip tests**\r\n\r\n## Related failing-test issues\r\n\r\n1.
https://github.com/elastic/kibana/issues/166102\r\n2.
https://github.com/elastic/kibana/issues/166105\r\n\r\n## Flaky test
runner
link\r\n\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3586\r\n🟢\r\n\r\n##
Changes\r\n\r\n- Unskipping skipped Accessibility integration
tests.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"6beee472486c547adf5a7a0033f7c01c197c6d02"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169223","number":169223,"mergeCommit":{"message":"[Security
Solution] Unskip `Security Solution Accessibility` tests (#169223)\n\n##
Summary\r\n\r\nFlaky test runner for Cypress tests:\r\n-
`x-pack/test/accessibility/apps/security_solution.ts`\r\n\r\n##
Changes\r\n\r\n-`x-pack/test/accessibility/apps/security_solution.ts`
**unskip tests**\r\n\r\n## Related failing-test issues\r\n\r\n1.
https://github.com/elastic/kibana/issues/166102\r\n2.
https://github.com/elastic/kibana/issues/166105\r\n\r\n## Flaky test
runner
link\r\n\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3586\r\n🟢\r\n\r\n##
Changes\r\n\r\n- Unskipping skipped Accessibility integration
tests.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"6beee472486c547adf5a7a0033f7c01c197c6d02"}}]}]
BACKPORT-->
@jpdjere jpdjere mentioned this pull request Nov 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yctercero yctercero yctercero approved these changes

Assignees

@jpdjere jpdjere

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.11.0 v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jpdjere @elasticmachine @kibana-ci @yctercero @kibanamachine