-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Enable Serverless for entity_analytics
Cypress tests
#169209
[Security Solution] Enable Serverless for entity_analytics
Cypress tests
#169209
Conversation
entity_analytics
Cypress testsentity_analytics
Cypress tests
f1da44f
to
d11b66f
Compare
26f4e89
to
08b4c01
Compare
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @jpdjere |
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
entity_analytics
Cypress testsentity_analytics
Cypress tests
cc @rylnd @nkhristinin not sure if there's any work being done on these or if we're good to enable and merge. |
Edit: I see now that those flaky tests are still skipped in this PR. If the (main) build is green, I've got no objections to merging this!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flaky tests are still skipped, and that work is captured in #169154. LGTM!
…tests (elastic#169209) Running flaky test runner for `x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics` - `x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/enrichments.cy.ts` **unskipped whole test suite in favour of failing test -> `Custom Query rule - from legacy risk scores`** (see below) **also enabled on Serverless** - `x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/entity_analytics_management_page.cy.ts` **enabled on Serverless** 1. elastic#169154 **Marked as legit-flake and assigned to @elastic/security-detection-engine** - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3575 (cherry picked from commit 12975a5)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…ypress tests (#169209) (#169682) # Backport This will backport the following commits from `main` to `8.11`: - [[Security Solution] Enable Serverless for `entity_analytics` Cypress tests (#169209)](#169209) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Juan Pablo Djeredjian","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-24T08:26:15Z","message":"[Security Solution] Enable Serverless for `entity_analytics` Cypress tests (#169209)\n\n## Summary\r\n\r\nRunning flaky test runner for\r\n`x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics`\r\n\r\n## Changes\r\n\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/enrichments.cy.ts`\r\n**unskipped whole test suite in favour of failing test -> `Custom Query\r\nrule - from legacy risk scores`** (see below) **also enabled on\r\nServerless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/entity_analytics_management_page.cy.ts`\r\n**enabled on Serverless**\r\n\r\n## Related failing-test issues\r\n\r\n1. https://github.com/elastic/kibana/issues/169154\r\n**Marked as legit-flake and assigned to\r\n@elastic/security-detection-engine**\r\n\r\n### Flaky test runner link\r\n\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3575","sha":"12975a5a0c6846d5cdbecc73beceba0346cd866b","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","Team:Detections and Resp","Team:Detection Engine","v8.12.0"],"number":169209,"url":"https://github.com/elastic/kibana/pull/169209","mergeCommit":{"message":"[Security Solution] Enable Serverless for `entity_analytics` Cypress tests (#169209)\n\n## Summary\r\n\r\nRunning flaky test runner for\r\n`x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics`\r\n\r\n## Changes\r\n\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/enrichments.cy.ts`\r\n**unskipped whole test suite in favour of failing test -> `Custom Query\r\nrule - from legacy risk scores`** (see below) **also enabled on\r\nServerless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/entity_analytics_management_page.cy.ts`\r\n**enabled on Serverless**\r\n\r\n## Related failing-test issues\r\n\r\n1. https://github.com/elastic/kibana/issues/169154\r\n**Marked as legit-flake and assigned to\r\n@elastic/security-detection-engine**\r\n\r\n### Flaky test runner link\r\n\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3575","sha":"12975a5a0c6846d5cdbecc73beceba0346cd866b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169209","number":169209,"mergeCommit":{"message":"[Security Solution] Enable Serverless for `entity_analytics` Cypress tests (#169209)\n\n## Summary\r\n\r\nRunning flaky test runner for\r\n`x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics`\r\n\r\n## Changes\r\n\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/enrichments.cy.ts`\r\n**unskipped whole test suite in favour of failing test -> `Custom Query\r\nrule - from legacy risk scores`** (see below) **also enabled on\r\nServerless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/entity_analytics_management_page.cy.ts`\r\n**enabled on Serverless**\r\n\r\n## Related failing-test issues\r\n\r\n1. https://github.com/elastic/kibana/issues/169154\r\n**Marked as legit-flake and assigned to\r\n@elastic/security-detection-engine**\r\n\r\n### Flaky test runner link\r\n\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3575","sha":"12975a5a0c6846d5cdbecc73beceba0346cd866b"}}]}] BACKPORT-->
Summary
Running flaky test runner for
x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics
Changes
x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/enrichments.cy.ts
unskipped whole test suite in favour of failing test ->Custom Query rule - from legacy risk scores
(see below) also enabled on Serverlessx-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/entity_analytics_management_page.cy.ts
enabled on ServerlessRelated failing-test issues
Marked as legit-flake and assigned to @elastic/security-detection-engine
Flaky test runner link