Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Address issue with defaultColumns when changing data views #168994

Merged
merged 9 commits into from
Nov 16, 2023

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Oct 16, 2023

Summary

This PR re-adds default columns when changing data views. Only columns which are present in the data view will be re-added.

For testing: configure some fields for defaultColumns on Advanced Settings page and test switching data views on Discover page.

Checklist

@jughosta jughosta added Feature:Discover Discover Application release_note:fix backport:skip This commit does not require backporting Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Oct 16, 2023
@jughosta jughosta self-assigned this Oct 16, 2023
@jughosta jughosta closed this Oct 18, 2023
@kertal kertal reopened this Nov 6, 2023
@jughosta jughosta changed the title [Discover] Address issue with defaultColumns when changing data views PoC [Discover] Address issue with defaultColumns when changing data views Nov 14, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 590.3KB 590.3KB +85.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

@jughosta jughosta marked this pull request as ready for review November 14, 2023 15:25
@jughosta jughosta requested review from a team as code owners November 14, 2023 15:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kbn-test changes LGTM

Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good, and I tested locally and ran the new functional tests and everything worked as expected according to #168581 👍 LGTM and thanks for fixing it!

@jughosta jughosta merged commit 57b5546 into elastic:main Nov 16, 2023
26 checks passed
@jughosta jughosta deleted the 168581-fix-default-columns-on-switch branch November 16, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Discover Discover Application release_note:fix Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Discover] Default Columns do not always apply with switching Data Views
8 participants