-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Address issue with defaultColumns when changing data views #168994
[Discover] Address issue with defaultColumns when changing data views #168994
Conversation
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @jughosta |
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kbn-test
changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good, and I tested locally and ran the new functional tests and everything worked as expected according to #168581 👍 LGTM and thanks for fixing it!
Summary
This PR re-adds default columns when changing data views. Only columns which are present in the data view will be re-added.
For testing: configure some fields for
defaultColumns
on Advanced Settings page and test switching data views on Discover page.Checklist