Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Exceptions][API testing] Move and restructures exception groups in the new api integration test folder #168700

Merged
merged 20 commits into from
Oct 18, 2023
Merged

[Security Solution][Exceptions][API testing] Move and restructures exception groups in the new api integration test folder #168700

merged 20 commits into from
Oct 18, 2023

Conversation

WafaaNasr
Copy link
Contributor

@WafaaNasr WafaaNasr commented Oct 12, 2023 •
edited
Loading

Summary

@WafaaNasr WafaaNasr self-assigned this Oct 12, 2023
@WafaaNasr WafaaNasr added release_note:skip Skip the PR/issue when compiling release notes FTR labels Oct 12, 2023
@WafaaNasr WafaaNasr marked this pull request as ready for review October 16, 2023 09:09
@WafaaNasr WafaaNasr requested review from a team as code owners October 16, 2023 09:09
@WafaaNasr
Copy link
Contributor Author

@elasticmachine merge upstream

@maximpn maximpn mentioned this pull request Oct 16, 2023
Closed
3 tasks
jbudz
jbudz approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ftr_configs.yml

WafaaNasr and others added 7 commits October 17, 2023 11:23
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @WafaaNasr

e40pud
e40pud approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@e40pud e40pud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM

x-pack/test/security_solution_api_integration/config/serverless/config.base.ts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need these changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point no!
Will remove it, thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove it sorry in the next PR since I branched out from this PR and have many local changes 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here we go https://github.com/elastic/kibana/pull/169234/files#diff-afe1f42d5ac2006de8dc09069448b9e8734a6a950586376cd6e8eeb9110ab5f1R7

@WafaaNasr WafaaNasr merged commit e536a0a into elastic:main Oct 18, 2023
@WafaaNasr WafaaNasr deleted the move-restructure-exception-api-tests branch October 18, 2023 12:20
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Oct 18, 2023
@WafaaNasr WafaaNasr mentioned this pull request Nov 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

@e40pud e40pud e40pud approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting FTR release_note:skip Skip the PR/issue when compiling release notes v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WafaaNasr @kibana-ci @e40pud @jbudz @kibanamachine