Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Enable agent upgrade tooltip #168638

Merged
merged 3 commits into from
Nov 21, 2023
Merged

[Fleet] Enable agent upgrade tooltip #168638

merged 3 commits into from
Nov 21, 2023

Conversation

jillguyonnet
Copy link
Contributor

@jillguyonnet jillguyonnet commented Oct 11, 2023 •
edited
Loading

Summary

Followup to #167539.

Closes https://github.com/elastic/ingest-dev/issues/2568.

As the version on which agents will have upgrade details is not known yet, we decided to defer showing the tooltip for agents that don't until it is (cf. #167539 (comment)).

This PR sets the version to 8.12.

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@jillguyonnet jillguyonnet self-assigned this Oct 11, 2023
@jillguyonnet jillguyonnet added Team:Fleet Team label for Observability Data Collection Fleet team release_note:skip Skip the PR/issue when compiling release notes v8.12.0 labels Oct 11, 2023
@jillguyonnet jillguyonnet mentioned this pull request Oct 11, 2023
Merged
5 tasks
@jillguyonnet
Copy link
Contributor Author

@elasticmachine merge upstream

@jillguyonnet jillguyonnet force-pushed the fleet/enable-agent-upgrade-tooltip branch from 94e33bb to 462571f Compare October 23, 2023 14:01
@jillguyonnet
Copy link
Contributor Author

@elasticmachine merge upstream

@jillguyonnet jillguyonnet mentioned this pull request Oct 31, 2023
Merged
@jillguyonnet jillguyonnet marked this pull request as ready for review November 20, 2023 17:39
@jillguyonnet jillguyonnet requested a review from a team as a code owner November 20, 2023 17:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@jillguyonnet
Copy link
Contributor Author

@elasticmachine merge upstream

jlind23
jlind23 approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@jlind23 jlind23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.2MB 1.2MB +325.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jillguyonnet

@jillguyonnet jillguyonnet merged commit e859b14 into elastic:main Nov 21, 2023
@jillguyonnet jillguyonnet deleted the fleet/enable-agent-upgrade-tooltip branch November 21, 2023 09:54
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlind23 jlind23 jlind23 approved these changes

Assignees

@jillguyonnet jillguyonnet

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jillguyonnet @apmmachine @elasticmachine @kibana-ci @jlind23 @kibanamachine